Discussions - Chromium-reviews

Description: This list will only be used to conduct code reviews of changes to Chromium's source. All email threads on this list will originate from code reviews. Please do not start new threads on this list. This is a high volume, high technical content mailing list.

	Add a filter that will stop the host sending unnecessary clipboard events to the clien… (issue 10399052)
	Reviewers: Wez, Message: ptal Description: [Chromoting] Add a filter that will stop the host sending unnecessary clipboard events to the client. The host does not yet send any clipboard events to the client. A follow-up CL will make that happen. BUG=117473 Please review this at [link]... more » By simonmor...@chromium.org - 4:25pm - 1 new of 1 message

	Making sure that base::GetModuleFromAddress() does not increment the module reference counter sinse… (issue 10391169)
	Reviewers: jar, Wez, Message: Please take a look. Description: Making sure that base::GetModuleFromAddress() does not increment the module reference counter sinse the rest of the code assume it does not. The original change was reverted by [link].... more » By alexe...@chromium.org - 4:22pm - 1 new of 1 message

	Reverting r133134 - Make sure that base::MessagePumpForUI from different modules are isolated from … (issue 10384209)
	Reviewers: alexeypa, jar, Wez, Message: Please take a look. Description: Reverting r133134 - Make sure that base::MessagePumpForUI from different modules are isolated from each other and add protection from shatter attacks by placing ...(instead of blindly trusting the value of WPARAM).... more » By alexe...@chromium.org - 4:22pm - 1 new of 1 message

	Merge 137292 - Use distributed notifications instead of polling to determine success/failure of the… (issue 10398061)
	Reviewers: Jamie, Description: Merge 137292 - Use distributed notifications instead of polling to determine success/failure of the preference pane. BUG=128115 TEST=Manual Review URL: [link] TBR=jamiewa...@chromium.org Please review this at [link]... more » By jamiewa...@chromium.org - 4:21pm - 1 new of 1 message

	Merge 137486 - Remove the Docs default app. (issue 10392133)
	Reviewers: Mihai Parparita, Description: Merge 137486 - Remove the Docs default app. BUG=114644 R=asarg...@chromium.org TEST=Docs should no longer show up as a default app for new profiles Review URL: [link] TBR=mih...@chromium.org Please review this at [link]... more » By mih...@chromium.org - 4:19pm - 1 new of 1 message

	Merge 136153 - Remove log spam from audio_manager_linux.cc (issue 10377175)
	Reviewers: DaleCurtis, Description: Merge 136153 - Remove log spam from audio_manager_linux.cc [link] seems to have introduced some accidental log spam. Intended? BUG=128393 TEST=none Review URL: [link] TBR=dalecur...@chromium.org... more » By scher...@chromium.org - 4:18pm - 1 new of 1 message

Add selectFileForSave method to chrome.fileBrowserHandler (issue 10387124)

Reviewers: Aaron Boodman, Message: Hey Aaron, Can you take a look at this? Thanks, Toni Description: Add selectFileForSave method to chrome.fileBrowserHandler The method shows save as dialog asking user to select a file path that the extension can overwrite. When the file path is selected, method creates or truncates the file (depending on... more »

By tbar...@chromium.org - 4:09pm - 1 new of 1 message

	Base: Crash the process if we are not able to join threads. (issue 10398060)
	Reviewers: willchan, Description: Base: Crash the process if we are not able to join threads. BUG=127931 TEST=none Please review this at [link] SVN Base: svn://svn.chromium.org/chrome/ trunk/src/ Affected files: M base/threading/platform_thread _win.cc... more » By rvar...@chromium.org - 4:06pm - 2 new of 2 messages

	ash: Add a heads-up display to track touch-point states and positions. (issue 10386178)
	Reviewers: Ben Goodger (Google), Description: ash: Add a heads-up display to track touch-point states and positions. The command-line flag to turn on the HUD is --ash-touch-hud. It can also be turned on from about:flags BUG=none TEST=manually Please review this at [link]... more » By sad...@chromium.org - 4:05pm - 2 new of 2 messages

	mac: Unbreak shared build. (issue 10389178)
	Reviewers: Lambros, Description: mac: Unbreak shared build. It was broken by [link]. SOLINK_MODULE(target) out/Release/remoting_host_pref pane.prefPane/Contents/MacOS/r emoting_host_prefpane Undefined symbols: "_modp_b64_decode", referenced from:... more » By tha...@chromium.org - 4:02pm - 2 new of 2 messages

1 - 10 of 103036 « Newer | Older »

XML Send email to this group: chromium-reviews@chromium.org

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy

Account Options