Remove base/metrics/* code from NaCl IPC proxy build. (issue 11313014)

[bbu...@chromium.org]

Reviewers: jar,

Message:
Trying to relieve Brett's review load. This CL removes unneeded code for the
Chrome IPC proxy and should only affect IRT .nexe builds (code that runs in
the
NaCl inner sandbox.)

It does require some code in message_loop.cc to be commented out for
OS_NACL.

Description:
Remove base/metrics/* code from NaCl IPC proxy build.
This makes the IPC IRT nexes quite a bit smaller.
BUG=116317
TEST=compiles

Please review this at http://codereview.chromium.org/11313014/

SVN Base: svn://svn.chromium.org/chrome/trunk/src/

Affected files:
M base/base.gypi
M base/message_loop.cc


Index: base/base.gypi
===================================================================
--- base/base.gypi (revision 164256)
+++ base/base.gypi (working copy)
@@ -579,6 +579,17 @@
'file_util_posix.cc',
'file_util_proxy.cc',
'files/file_path_watcher_kqueue.cc',
+ 'metrics/sample_map.cc',
+ 'metrics/sample_vector.cc',
+ 'metrics/bucket_ranges.cc',
+ 'metrics/histogram.cc',
+ 'metrics/histogram_base.cc',
+ 'metrics/histogram_samples.cc',
+ 'metrics/histogram_snapshot_manager.cc',
+ 'metrics/sparse_histogram.cc',
+ 'metrics/statistics_recorder.cc',
+ 'metrics/stats_counters.cc',
+ 'metrics/stats_table.cc',
'native_library_posix.cc',
'path_service.cc',
'platform_file_posix.cc',
Index: base/message_loop.cc
===================================================================
--- base/message_loop.cc (revision 164256)
+++ base/message_loop.cc (working copy)
@@ -620,6 +620,7 @@
// on each thread.

void MessageLoop::StartHistogrammer() {
+#if !defined(OS_NACL) // NaCl build has no metrics code.
if (enable_histogrammer_ && !message_histogram_
&& base::StatisticsRecorder::IsActive()) {
DCHECK(!thread_name_.empty());
@@ -630,11 +631,14 @@
message_histogram_->kHexRangePrintingFlag);
message_histogram_->SetRangeDescriptions(event_descriptions_);
}
+#endif
}

void MessageLoop::HistogramEvent(int event) {
+#if !defined(OS_NACL)
if (message_histogram_)
message_histogram_->Add(event);
+#endif
}

bool MessageLoop::DoWork() {

[j...@chromium.org]

lgtm



http://codereview.chromium.org/11313014/

[commi...@chromium.org]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbu...@chromium.org/11313014/5001


https://chromiumcodereview.appspot.com/11313014/

[commi...@chromium.org]

Retried try job too often for step(s) chrome_frame_net_tests,
sync_integration_tests

https://chromiumcodereview.appspot.com/11313014/

[commi...@chromium.org]

[commi...@chromium.org]

Change committed as 164566

https://chromiumcodereview.appspot.com/11313014/