Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium-reviews
+ new post
About this group
Join this group
Message from discussion Add a new ContentRendererClient::HandleN avigation callback in RenderViewImpl::decidePolicyFo rNaviga… (issue 11293157)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
cr...@chromium.org  
View profile  
 More options Nov 8 2012, 2:06 pm
From: cr...@chromium.org
Date: Thu, 08 Nov 2012 19:06:12 +0000
Local: Thurs, Nov 8 2012 2:06 pm
Subject: Re: Add a new ContentRendererClient::HandleNavigation callback in RenderViewImpl::decidePolicyForNaviga… (issue 11293157)
Print | View thread | Show original | Find messages by this author
See my comments on the bug about whether we should add this API, but here's  
a
comment in case we decide to.

https://codereview.chromium.org/11293157/diff/1/content/renderer/rend...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/11293157/diff/1/content/renderer/rend...
content/renderer/render_view_impl.cc:2677: if
(GetContentClient()->renderer()->HandleNavigation(frame, request, type,
We do not want to do this when request.url() == GURL(kSwappedOutURL).
That's an internal implementation URL that should not be exposed to
embedders or the browser process.

I think adding that to this condition is probably the right thing to do.

https://codereview.chromium.org/11293157/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google