Update policy presubmit chat after two policies were renamed (issue 11271018)

16 views
Skip to first unread message

bar...@chromium.org

unread,
Oct 25, 2012, 4:06:39 AM10/25/12
to joaod...@chromium.org, chromium...@chromium.org
Reviewers: Joao da Silva,

Message:
Hi Joao, could you please have a look?

Description:
Update policy presubmit chat after two policies were renamed

The policies related to Drive were renamed from GData* to Drive*. This
CL updates the policy presubmit check accordingly.

BUG=None


Please review this at https://codereview.chromium.org/11271018/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
M chrome/app/policy/syntax_check_policy_template_json.py


Index: chrome/app/policy/syntax_check_policy_template_json.py
diff --git a/chrome/app/policy/syntax_check_policy_template_json.py
b/chrome/app/policy/syntax_check_policy_template_json.py
index
8cfcbb3d2bb9bed587b2742df882457b7e781b9a..a2d51952f49ad7fbc6d776bb5423723f2bbaae12
100755
--- a/chrome/app/policy/syntax_check_policy_template_json.py
+++ b/chrome/app/policy/syntax_check_policy_template_json.py
@@ -44,8 +44,8 @@ LEGACY_INVERTED_POLARITY_WHITELIST = [
'DisableSpdy',
'DisableSSLRecordSplitting',
'ExternalStorageDisabled',
- 'GDataDisabled',
- 'GDataDisabledOverCellular',
+ 'DriveDisabled',
+ 'DriveDisabledOverCellular',
'SavingBrowserHistoryDisabled',
'SyncDisabled',
]


joaod...@chromium.org

unread,
Oct 25, 2012, 4:13:04 AM10/25/12
to bar...@chromium.org, chromium...@chromium.org
lgtm


https://codereview.chromium.org/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py
File chrome/app/policy/syntax_check_policy_template_json.py (right):

https://codereview.chromium.org/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py#newcode48
chrome/app/policy/syntax_check_policy_template_json.py:48:
'DriveDisabledOverCellular',
nit: alphabetical order

https://codereview.chromium.org/11271018/

bar...@chromium.org

unread,
Oct 25, 2012, 4:14:24 AM10/25/12
to joaod...@chromium.org, chromium...@chromium.org

https://chromiumcodereview.appspot.com/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py
File chrome/app/policy/syntax_check_policy_template_json.py (right):

https://chromiumcodereview.appspot.com/11271018/diff/1/chrome/app/policy/syntax_check_policy_template_json.py#newcode48
chrome/app/policy/syntax_check_policy_template_json.py:48:
'DriveDisabledOverCellular',
On 2012/10/25 08:13:04, Joao da Silva wrote:
> nit: alphabetical order

Done.

https://chromiumcodereview.appspot.com/11271018/

commi...@chromium.org

unread,
Oct 25, 2012, 4:14:58 AM10/25/12
to bar...@chromium.org, joaod...@chromium.org, chromium...@chromium.org

commi...@chromium.org

unread,
Oct 25, 2012, 5:15:55 AM10/25/12
to bar...@chromium.org, joaod...@chromium.org, chromium...@chromium.org
Retried try job too often for step(s) unit_tests

https://chromiumcodereview.appspot.com/11271018/
Reply all
Reply to author
Forward
0 new messages