Account Options

  1. Sign in
The old Google Groups will be going away soon.
Switch to the new Google Groups.
Google Groups Home for chromium.org
« Groups Home
Chromium-reviews
+ new post
About this group
Join this group
Message from discussion Adding a sample CWS license server client written for Python App Engine. (issue3161030)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
bkenn...@chromium.org  
View profile  
 More options Aug 19 2010, 6:58 pm
From: bkenn...@chromium.org
Date: Thu, 19 Aug 2010 22:58:27 +0000
Local: Thurs, Aug 19 2010 6:58 pm
Subject: Re: Adding a sample CWS license server client written for Python App Engine. (issue3161030)
Print | View thread | Show original | Find messages by this author

http://codereview.chromium.org/3161030/diff/1/9
File chrome/common/extensions/docs/examples/apps/hello-python/main.py
(right):

http://codereview.chromium.org/3161030/diff/1/9#newcode114
chrome/common/extensions/docs/examples/apps/hello-python/main.py:114:
userid = user.federated_identity() or user.user_id()
I don't think falling back to the Google account ID (or any other value)
is a good practice as doing so could mask a set of nasty bugs in
production code. An app that fails to acquire a user's federated
identity will proceed with the fallback value unaware anything is wrong.

Instead, I think we should change our doc to insist on deploying to test
an app's login flow.

http://codereview.chromium.org/3161030/show


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2012 Google