Extends IBusText to handle mozc's extended field. (issue 11363033)

17 views
Skip to first unread message

no...@chromium.org

unread,
Nov 2, 2012, 5:07:28 AM11/2/12
to sat...@chromium.org, chromium...@chromium.org, stevenj...@chromium.org, oshima...@chromium.org, hsu...@chromium.org
Reviewers: satorux1,

Description:
Extends IBusText to handle mozc's extended field.

This is part of mozc dependency removal and libibus removal.

BUG=129403
TEST=ran chromeos_unittests


Please review this at http://codereview.chromium.org/11363033/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
M chromeos/dbus/ibus/ibus_text.h
M chromeos/dbus/ibus/ibus_text.cc
M chromeos/dbus/ibus/ibus_text_unittest.cc


sat...@chromium.org

unread,
Nov 4, 2012, 11:29:16 PM11/4/12
to no...@chromium.org, chromium...@chromium.org, stevenj...@chromium.org, oshima...@chromium.org, hsu...@chromium.org

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h
File chromeos/dbus/ibus/ibus_text.h (right):

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h#newcode144
chromeos/dbus/ibus/ibus_text.h:144: std::string text() const { return
text_; }
const std::string& text()

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h#newcode147
chromeos/dbus/ibus/ibus_text.h:147: std::string annotation() const {
return annotation_; }
ditto. please fix other places too.

http://codereview.chromium.org/11363033/

no...@chromium.org

unread,
Nov 5, 2012, 12:27:42 AM11/5/12
to sat...@chromium.org, chromium...@chromium.org, stevenj...@chromium.org, oshima...@chromium.org, hsu...@chromium.org

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h
File chromeos/dbus/ibus/ibus_text.h (right):

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h#newcode144
chromeos/dbus/ibus/ibus_text.h:144: std::string text() const { return
text_; }
On 2012/11/05 04:29:16, satorux1 wrote:
> const std::string& text()

Done.

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h#newcode147
chromeos/dbus/ibus/ibus_text.h:147: std::string annotation() const {
return annotation_; }
On 2012/11/05 04:29:16, satorux1 wrote:
> ditto. please fix other places too.

Done.

http://codereview.chromium.org/11363033/

sat...@chromium.org

unread,
Nov 5, 2012, 10:53:08 PM11/5/12
to no...@chromium.org, chromium...@chromium.org, stevenj...@chromium.org, oshima...@chromium.org, hsu...@chromium.org
LGTM

http://codereview.chromium.org/11363033/

commi...@chromium.org

unread,
Nov 6, 2012, 1:32:07 AM11/6/12
to no...@chromium.org, sat...@chromium.org, chromium...@chromium.org, stevenj...@chromium.org, oshima...@chromium.org, hsu...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/no...@chromium.org/11363033/5001


https://chromiumcodereview.appspot.com/11363033/

commi...@chromium.org

unread,
Nov 6, 2012, 3:22:36 AM11/6/12
to no...@chromium.org, sat...@chromium.org, chromium...@chromium.org, stevenj...@chromium.org, oshima...@chromium.org, hsu...@chromium.org
Change committed as 166175

https://chromiumcodereview.appspot.com/11363033/
Reply all
Reply to author
Forward
0 new messages