Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium-reviews
+ new post
About this group
Join this group
Message from discussion google_apis: Remove PostBlockingPoolSequencedTask () and friends (issue 11363234)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
sato...@chromium.org  
View profile  
 More options Nov 14 2012, 2:14 am
From: sato...@chromium.org
Date: Wed, 14 Nov 2012 07:14:30 +0000
Local: Wed, Nov 14 2012 2:14 am
Subject: Re: google_apis: Remove PostBlockingPoolSequencedTask () and friends (issue 11363234)
Print | View thread | Show original | Find messages by this author

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
File chrome/browser/google_apis/gdata_util.h (right):

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:9:
added "base/string_piece.h". StringPiece cannot be forward-declared.

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:10: #include
"base/callback_forward.h"
On 2012/11/14 06:30:18, hashimoto wrote:

> No need to include this.

Done.

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:11: #include "base/logging.h"
On 2012/11/14 06:30:18, hashimoto wrote:

> ditto.

Done.

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:12: #include
"base/platform_file.h"
On 2012/11/14 06:30:18, hashimoto wrote:

> ditto.

Done.

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:13: #include
"base/task_runner_util.h"
On 2012/11/14 06:30:18, hashimoto wrote:

> ditto.

Done.

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:14: #include
"chrome/browser/google_apis/gdata_errorcode.h"
On 2012/11/14 06:30:18, hashimoto wrote:

> ditto.

Done.

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:20: class SequencedTaskRunner;
removed

http://codereview.chromium.org/11363234/diff/4001/chrome/browser/goog...
chrome/browser/google_apis/gdata_util.h:26: }  // tracked_objects
removed.

http://codereview.chromium.org/11363234/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google