Added PAM configuration. (issue 11359043)

27 views
Skip to first unread message

jamie...@chromium.org

unread,
Nov 2, 2012, 2:30:53 PM11/2/12
to lambros...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, rmsous...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
Reviewers: Lambros,

Message:
ptal

Description:
Added PAM configuration.

BUG=159037


Please review this at https://codereview.chromium.org/11359043/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
A remoting/host/installer/linux/debian/chrome-remote-desktop.pam


Index: remoting/host/installer/linux/debian/chrome-remote-desktop.pam
diff --git a/remoting/host/installer/linux/debian/chrome-remote-desktop.pam
b/remoting/host/installer/linux/debian/chrome-remote-desktop.pam
new file mode 100644
index
0000000000000000000000000000000000000000..7fa64c85f03b9d64cca3f0c6bbcd426bbe9c9beb
--- /dev/null
+++ b/remoting/host/installer/linux/debian/chrome-remote-desktop.pam
@@ -0,0 +1,6 @@
+# We fall back to the system default in /etc/pam.d/common-*
+
+@include common-auth
+@include common-account
+@include common-password
+@include common-session


lambros...@chromium.org

unread,
Nov 2, 2012, 5:40:31 PM11/2/12
to jamie...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, rmsous...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
lgtm


http://codereview.chromium.org/11359043/diff/1/remoting/host/installer/linux/debian/chrome-remote-desktop.pam
File remoting/host/installer/linux/debian/chrome-remote-desktop.pam
(right):

http://codereview.chromium.org/11359043/diff/1/remoting/host/installer/linux/debian/chrome-remote-desktop.pam#newcode1
remoting/host/installer/linux/debian/chrome-remote-desktop.pam:1: # We
fall back to the system default in /etc/pam.d/common-*
nit: Add copyright.
nit: End sentence with dot?
nit: plural "defaults"?
nit: Remove "We"?
I'm not sure this comment adds anything useful for the sys-admin, so I
think it's OK to remove it. As it is, the comment might convey the
message that it's a bad idea to edit this file.

http://codereview.chromium.org/11359043/

jamie...@chromium.org

unread,
Nov 2, 2012, 8:45:37 PM11/2/12
to lambros...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, rmsous...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
Done. The comment was essentially copied from pam.d/other, which is what
this
file was based on. I agree it doesn't add anything. I've also added a
copyright
notice.

https://codereview.chromium.org/11359043/

commi...@chromium.org

unread,
Nov 2, 2012, 8:47:10 PM11/2/12
to jamie...@chromium.org, lambros...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, rmsous...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamie...@chromium.org/11359043/5001


https://chromiumcodereview.appspot.com/11359043/

commi...@chromium.org

unread,
Nov 3, 2012, 12:24:39 AM11/3/12
to jamie...@chromium.org, lambros...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, rmsous...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
Retried try job too often for step(s) content_browsertests

https://chromiumcodereview.appspot.com/11359043/

commi...@chromium.org

unread,
Nov 3, 2012, 3:15:11 AM11/3/12
to jamie...@chromium.org, lambros...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, rmsous...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org

commi...@chromium.org

unread,
Nov 3, 2012, 12:51:16 PM11/3/12
to jamie...@chromium.org, lambros...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, rmsous...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
Change committed as 165855

https://chromiumcodereview.appspot.com/11359043/
Reply all
Reply to author
Forward
0 new messages