Received: by 10.236.193.73 with SMTP id j49mr6177695yhn.7.1352402162295;
        Thu, 08 Nov 2012 11:16:02 -0800 (PST)
X-BeenThere: chromium-revi...@chromium.org
Received: by 10.236.142.209 with SMTP id i57ls5292087yhj.2.gmail; Thu, 08 Nov
 2012 11:16:00 -0800 (PST)
Received: by 10.236.35.131 with SMTP id u3mr9732427yha.12.1352402160282;
        Thu, 08 Nov 2012 11:16:00 -0800 (PST)
Received: by 10.236.35.131 with SMTP id u3mr9732424yha.12.1352402160268;
        Thu, 08 Nov 2012 11:16:00 -0800 (PST)
Return-Path: <37wScUBUJAPIWbligcogWiXYlYpcYq-blagUcf....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com>
Received: from mail-gg0-f199.google.com (mail-gg0-f199.google.com [209.85.161.199])
        by mx.google.com with ESMTPS id m20si9551317anh.131.2012.11.08.11.15.59
        (version=TLSv1/SSLv3 cipher=OTHER);
        Thu, 08 Nov 2012 11:15:59 -0800 (PST)
Received-SPF: pass (google.com: domain of 37wScUBUJAPIWbligcogWiXYlYpcYq-blagUcf....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.161.199 as permitted sender) client-ip=209.85.161.199;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of 37wScUBUJAPIWbligcogWiXYlYpcYq-blagUcf....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.161.199 as permitted sender) smtp.mail=37wScUBUJAPIWbligcogWiXYlYpcYq-blagUcf....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com; dkim=pass header...@chromium.org
Received: by mail-gg0-f199.google.com with SMTP id f1so5266321ggn.10
        for <chromium-revi...@chromium.org>; Thu, 08 Nov 2012 11:15:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=chromium.org; s=google;
        h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
         :subject:from:to:cc:content-type;
        bh=vq13iCgkKz6q0Ht6X00mR4Iv9ZYG0C036QQD36ho5OI=;
        b=nrFCbenhm7pXKmyh4L0K8qBIBeAfKeSA9nuH8gl7vsXG7FQvka4j04Ya8zKHQctYML
         gCHRi6sAIDnJUx6wanxmdeKOE/gBgf3elQCPj3TufD+GEijXbXC89rHWw3Boe9wN1xQx
         7LQnGZKisYtJYV++yOz6spZBsKxuqWbsVYdXM=
MIME-Version: 1.0
Received: by 10.58.221.132 with SMTP id qe4mr1516778vec.9.1352402159104; Thu,
 08 Nov 2012 11:15:59 -0800 (PST)
Reply-To: marsh...@chromium.org, cr...@chromium.org, j...@chromium.org, 
	chromium-revi...@chromium.org, joi+watch-cont...@chromium.org, 
	darin...@chromium.org
Message-ID: <047d7bf0efc449746f04ce00a...@google.com>
Date: Thu, 08 Nov 2012 19:15:59 +0000
Subject: =?windows-1252?Q?Re=3A_Add_a_new_ContentRendererClient=3A=3AHandleNavigatio?=
	=?windows-1252?Q?n_callback_in_RenderViewImpl=3A=3AdecidePolicyForNaviga=85_=28issu?=
	=?windows-1252?Q?e_11293157=29?=
From: marsh...@chromium.org
To: cr...@chromium.org, j...@chromium.org
Cc: chromium-revi...@chromium.org, joi+watch-cont...@chromium.org, 
	darin...@chromium.org, j...@chromium.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes


https://codereview.chromium.org/11293157/diff/1/content/renderer/render_view_impl.cc
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/11293157/diff/1/content/renderer/render_view_impl.cc#newcode2677
content/renderer/render_view_impl.cc:2677: if
(GetContentClient()->renderer()->HandleNavigation(frame, request, type,
On 2012/11/08 19:06:12, creis wrote:
> We do not want to do this when request.url() == GURL(kSwappedOutURL).
That's an
> internal implementation URL that should not be exposed to embedders or
the
> browser process.

> I think adding that to this condition is probably the right thing to
do.

Done.

https://codereview.chromium.org/11293157/