Received: by 10.101.2.7 with SMTP id e7mr2257978ani.14.1351014974020;
        Tue, 23 Oct 2012 10:56:14 -0700 (PDT)
X-BeenThere: chromium-revi...@chromium.org
Received: by 10.236.149.73 with SMTP id w49ls1157980yhj.5.gmail; Tue, 23 Oct
 2012 10:56:12 -0700 (PDT)
Received: by 10.236.73.70 with SMTP id u46mr12225080yhd.59.1351014972696;
        Tue, 23 Oct 2012 10:56:12 -0700 (PDT)
Received: by 10.236.73.70 with SMTP id u46mr12225078yhd.59.1351014972678;
        Tue, 23 Oct 2012 10:56:12 -0700 (PDT)
Return-Path: <3PNqGUBUJAJU16GDB7JB1D23G3K73L-6G5Bz7A....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com>
Received: from mail-gh0-f197.google.com (mail-gh0-f197.google.com [209.85.160.197])
        by mx.google.com with ESMTPS id w47si10174251yhi.114.2012.10.23.10.56.12
        (version=TLSv1/SSLv3 cipher=OTHER);
        Tue, 23 Oct 2012 10:56:12 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3PNqGUBUJAJU16GDB7JB1D23G3K73L-6G5Bz7A....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.160.197 as permitted sender) client-ip=209.85.160.197;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of 3PNqGUBUJAJU16GDB7JB1D23G3K73L-6G5Bz7A....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com designates 209.85.160.197 as permitted sender) smtp.mail=3PNqGUBUJAJU16GDB7JB1D23G3K73L-6G5Bz7A....@2uix4h7xygsz66weerlq.apphosting.bounces.google.com; dkim=pass header...@chromium.org
Received: by mail-gh0-f197.google.com with SMTP id f16so10015013ghb.4
        for <chromium-revi...@chromium.org>; Tue, 23 Oct 2012 10:56:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=chromium.org; s=google;
        h=mime-version:reply-to:x-google-appengine-app-id:message-id:date
         :subject:from:to:cc:content-type;
        bh=bS49p9iEXk8q4udLL5GtjyPm8nbC9rInAT4RpdXPYqg=;
        b=Jr6paoaI7gvDdWLWaHPBKDcfnShDqNKqavGtQfLG56j3/eFiIB3ju2yUcQMAp5zMDO
         uGO7u50aN3BzrfTU4j0IQ/w4O6EE4gjYfS+vqrHcb3deWvJ0t4AS3Rtk08w+6y2eL1h0
         ec/pg7C3L9Qo3mwiiVMflGfhEFNc0ceosP69s=
MIME-Version: 1.0
Received: by 10.59.5.193 with SMTP id co1mr4890883ved.37.1351014972544; Tue,
 23 Oct 2012 10:56:12 -0700 (PDT)
Reply-To: yongsheng....@intel.com, z...@chromium.org, j...@chromium.org, 
	chromium-revi...@chromium.org, joi+watch-cont...@chromium.org, 
	darin...@chromium.org, apatr...@chromium.org
Message-ID: <047d7b6d8b0a86569904ccbda...@google.com>
Date: Tue, 23 Oct 2012 17:56:12 +0000
Subject: Re: Enable gpu crash tests in content (issue 10984040)
From: z...@chromium.org
To: yongsheng....@intel.com, j...@chromium.org
Cc: chromium-revi...@chromium.org, joi+watch-cont...@chromium.org, 
	darin...@chromium.org, apatr...@chromium.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

LGTM

On 2012/10/23 05:51:42, yongsheng wrote:
> thanks for review.


http://codereview.chromium.org/10984040/diff/25001/content/browser/gpu/gpu_crash_browsertest.cc
> File content/browser/gpu/gpu_crash_browsertest.cc (left):


http://codereview.chromium.org/10984040/diff/25001/content/browser/gpu/gpu_crash_browsertest.cc#oldcode27
> content/browser/gpu/gpu_crash_browsertest.cc:27:
> chrome::SelectPreviousTab(browser);
> On 2012/10/22 22:54:33, Zhenyao Mo wrote:
> > This behavior is lost in the new test.  Is there a way to add this back?
> there is no function in shell to activate one.
>  From my tests, it can work without select another tab/shell.
> If it's necessary, we need to add functions in shell to support it.

Please do so in a separate CL.



http://codereview.chromium.org/10984040/diff/25001/content/browser/gpu/gpu_crash_browsertest.cc
> File content/browser/gpu/gpu_crash_browsertest.cc (right):


http://codereview.chromium.org/10984040/diff/25001/content/browser/gpu/gpu_crash_browsertest.cc#newcode45
> content/browser/gpu/gpu_crash_browsertest.cc:45:
> IN_PROC_BROWSER_TEST_F(GPUCrashTest, MANUAL_DISABLED_Kill) {
> On 2012/10/22 22:54:33, Zhenyao Mo wrote:
> > Remove DISABLED_
> done.



http://codereview.chromium.org/10984040/