Re: Roll third_party/pexpect 509:533 (issue 11360098)

unread,

Nov 8, 2012, 8:59:22 AM11/8/12

to nd...@chromium.org, open-source-thi...@google.com, phajd...@chromium.org, chromium...@chromium.org

the other patch for licensecheck.pl landed, thanks!
this is good to go, a quick look please?

http://codereview.chromium.org/11360098/

unread,

Nov 8, 2012, 12:42:04 PM11/8/12

to bul...@chromium.org, nd...@chromium.org, open-source-thi...@google.com, chromium...@chromium.org

unread,

Nov 8, 2012, 12:45:36 PM11/8/12

to nd...@chromium.org, open-source-thi...@google.com, phajd...@chromium.org, chromium...@chromium.org

thanks pawel! clarification below, will wait for
open-source-third-party-reviews@ to be on the safe side :)

On 2012/11/08 17:42:04, Paweł Hajdan Jr. wrote:
> Yay, removing an excpetion. Awesome!

:)

On 2012/11/08 17:42:04, Paweł Hajdan Jr. wrote:
> Just checking: do you need this? If so, OK.

yes, this is needed: sorry, I forgot to update the patch description,
done.

http://codereview.chromium.org/11360098/

unread,

Nov 12, 2012, 1:34:10 PM11/12/12

to bul...@chromium.org, nd...@chromium.org, open-source-thi...@google.com, phajd...@chromium.org, chromium...@chromium.org

unread,

Nov 12, 2012, 4:06:27 PM11/12/12

to bul...@chromium.org, nd...@chromium.org, open-source-thi...@google.com, phajd...@chromium.org, dan...@google.com, chromium...@chromium.org

unread,

Nov 13, 2012, 9:31:52 AM11/13/12

to bul...@chromium.org, nd...@chromium.org, open-source-thi...@google.com, phajd...@chromium.org, dan...@google.com, chromium...@chromium.org

unread,

Nov 13, 2012, 11:35:18 AM11/13/12

to bul...@chromium.org, nd...@chromium.org, open-source-thi...@google.com, phajd...@chromium.org, dan...@google.com, chromium...@chromium.org

Reply all

Reply to author

Forward