Re: [Autofill] Enable client-side pruning of old autocomplete data. (issue 11272043)

[ishe...@chromium.org]

Ping. Should I commit this as is, or do we want to lower the percentage?

https://chromiumcodereview.appspot.com/11272043/

[ishe...@chromium.org]

Tim, I've updated the code to set different probabilities depending on what
channel it's running as. PTAL, with apologies for asking you to review this
same CL twice.

https://chromiumcodereview.appspot.com/11272043/

[t...@chromium.org]

lgtm




https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc#newcode88
chrome/browser/webdata/autocomplete_syncable_service.cc:88: double
culling_probability;
It's best to initialize (to 0, I suppose).

https://chromiumcodereview.appspot.com/11272043/

[ishe...@chromium.org]

https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc
File chrome/browser/webdata/autocomplete_syncable_service.cc (right):

https://chromiumcodereview.appspot.com/11272043/diff/6001/chrome/browser/webdata/autocomplete_syncable_service.cc#newcode88
chrome/browser/webdata/autocomplete_syncable_service.cc:88: double
culling_probability;

On 2012/11/02 17:46:11, timsteele wrote:
> It's best to initialize (to 0, I suppose).

Done.

https://chromiumcodereview.appspot.com/11272043/

[commi...@chromium.org]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ishe...@chromium.org/11272043/6002


https://chromiumcodereview.appspot.com/11272043/

[commi...@chromium.org]

Presubmit check for 11272043-6002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
chrome

Was the presubmit check useful? Please send feedback & hate mail to
mar...@chromium.org!


https://chromiumcodereview.appspot.com/11272043/

[ishe...@chromium.org]

TBR Nico for OWNERS (I'm adding an OWNERS file for webdata/ in [
https://chromiumcodereview.appspot.com/11367055/ ]).

https://chromiumcodereview.appspot.com/11272043/

[ishe...@chromium.org]

(re-send mail after adding Nico to reviewers line)

https://chromiumcodereview.appspot.com/11272043/

[commi...@chromium.org]

[tha...@chromium.org]

lgtm stamp

https://chromiumcodereview.appspot.com/11272043/

[commi...@chromium.org]

Retried try job too often for step(s) content_browsertests

https://chromiumcodereview.appspot.com/11272043/

[commi...@chromium.org]

[commi...@chromium.org]

[commi...@chromium.org]

[commi...@chromium.org]

[commi...@chromium.org]

[commi...@chromium.org]

Change committed as 165888

https://chromiumcodereview.appspot.com/11272043/