ash: Add a heads-up display to track touch-point states and positions. (issue 10386178)

117 views
Skip to first unread message

sad...@chromium.org

unread,
May 16, 2012, 4:05:24 PM5/16/12
to b...@chromium.org, chromium...@chromium.org, ben+...@chromium.org
Reviewers: Ben Goodger (Google),

Description:
ash: Add a heads-up display to track touch-point states and positions.

The command-line flag to turn on the HUD is --ash-touch-hud. It can also be
turned on from about:flags

BUG=none
TEST=manually


Please review this at http://codereview.chromium.org/10386178/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
M ash/ash.gyp
M ash/ash_switches.h
M ash/ash_switches.cc
M ash/shell.h
M ash/shell.cc
A ash/touch/touch_observer_hud.h
A ash/touch/touch_observer_hud.cc
M chrome/app/generated_resources.grd
M chrome/browser/about_flags.cc


b...@chromium.org

unread,
May 16, 2012, 4:14:35 PM5/16/12
to sad...@chromium.org, chromium...@chromium.org, sad...@chromium.org, ben+...@chromium.org

http://codereview.chromium.org/10386178/diff/1011/ash/shell.cc
File ash/shell.cc (right):

http://codereview.chromium.org/10386178/diff/1011/ash/shell.cc#newcode697
ash/shell.cc:697: touch_observer_hud_->Initialize();
instead of having an init method, why not just construct the hud here?

http://codereview.chromium.org/10386178/

sad...@chromium.org

unread,
May 16, 2012, 4:35:55 PM5/16/12
to b...@chromium.org, chromium...@chromium.org, ben+...@chromium.org
On 2012/05/16 20:14:35, Ben Goodger (Google) wrote:
> instead of having an init method, why not just construct the hud here?

Done.

http://codereview.chromium.org/10386178/

b...@chromium.org

unread,
May 16, 2012, 4:51:03 PM5/16/12
to sad...@chromium.org, chromium...@chromium.org, sad...@chromium.org, ben+...@chromium.org
Reply all
Reply to author
Forward
0 new messages