Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Merge 164868 - Fix linking issue with CDM plugin wrapper and pre-built CDM. (issue 11363014)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  1 message - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
fisch...@chromium.org  
View profile  
 More options Oct 31 2012, 2:28 pm
From: fisch...@chromium.org
Date: Wed, 31 Oct 2012 18:28:31 +0000
Local: Wed, Oct 31 2012 2:28 pm
Subject: Merge 164868 - Fix linking issue with CDM plugin wrapper and pre-built CDM. (issue 11363014)
Reviewers: Ami Fischman,

Description:
Merge 164868 - Fix linking issue with CDM plugin wrapper and pre-built CDM.

BUG=149772

Review URL: https://codereview.chromium.org/11227048

TBR=fisch...@chromium.org

Please review this at https://codereview.chromium.org/11363014/

SVN Base: svn://svn.chromium.org/chrome/branches/1312/src/

Affected files:
   M     third_party/widevine/cdm/widevine_cdm.gyp

Index: third_party/widevine/cdm/widevine_cdm.gyp
===================================================================
--- third_party/widevine/cdm/widevine_cdm.gyp   (revision 165196)
+++ third_party/widevine/cdm/widevine_cdm.gyp   (working copy)
@@ -14,7 +14,6 @@
                  'symbols/chromeos/<(target_arch)/widevine_cdm_version.h',
              'widevine_cdm_binary_files%': [
                'binaries/chromeos/<(target_arch)/libwidevinecdm.so',
-              'binaries/chromeos/<(target_arch)/manifest.json',
              ],
            }],
            [ 'OS == "linux" and chromeos == 0', {
@@ -22,7 +21,6 @@
                  'symbols/linux/<(target_arch)/widevine_cdm_version.h',
              'widevine_cdm_binary_files%': [
                'binaries/linux/<(target_arch)/libwidevinecdm.so',
-              'binaries/linux/<(target_arch)/manifest.json',
              ],
            }],
            [ 'OS == "mac"', {
@@ -30,7 +28,6 @@
                  'symbols/mac/<(target_arch)/widevine_cdm_version.h',
              'widevine_cdm_binary_files%': [
                'binaries/mac/<(target_arch)/libwidevinecdm.dylib',
-              'binaries/mac/<(target_arch)/manifest.json',
              ],
            }],
            [ 'OS == "win"', {
@@ -38,7 +35,6 @@
                  'symbols/win/<(target_arch)/widevine_cdm_version.h',
              'widevine_cdm_binary_files%': [
                'binaries/win/<(target_arch)/widevinecdm.dll',
-              'binaries/win/<(target_arch)/manifest.json',
              ],
            }],
          ],
@@ -67,12 +63,15 @@
              [ 'os_posix == 1 and OS != "mac"', {
                'cflags': ['-fvisibility=hidden'],
                'type': 'loadable_module',
-              # -gstabs, used in the official builds, causes an ICE. Simply
-              # remove it.
-              'cflags!': ['-gstabs'],
                # Allow the plugin wrapper to find the CDM in the same  
directory.
-              'ldflags': ['-Wl,-rpath=\$$ORIGIN']
+              'ldflags': ['-Wl,-rpath=\$$ORIGIN'],
              }],
+            [ 'chromeos == 1 and target_arch == "arm"', {
+              'libraries': [
+                # Copied by widevine_cdm_binaries.
+                '<(PRODUCT_DIR)/libwidevinecdm.so',
+              ],
+            }],
              [ 'OS == "win" and 0', {
                'type': 'shared_library',
              }],
@@ -104,7 +103,8 @@
        'target_name': 'widevine_cdm_binaries',
        'type': 'none',
        'copies': [{
-        # TODO(ddorwin): Do we need a sub-directory?
+        # TODO(ddorwin): Do we need a sub-directory? We either need a
+        # sub-directory or to rename manifest.json before we can copy it.
          'destination': '<(PRODUCT_DIR)',
          'files': [ '<@(widevine_cdm_binary_files)' ],
        }],


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »