Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium-reviews
+ new post
About this group
Join this group
File upload API in chromedriver (issue7055004)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
hn...@google.com  
View profile  
 More options Jun 27 2011, 12:05 am
From: hn...@google.com
Date: Mon, 27 Jun 2011 04:05:53 +0000
Local: Mon, Jun 27 2011 12:05 am
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
File chrome/test/webdriver/chromedriver_tests.py (right):

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
chrome/test/webdriver/chromedriver_tests.py:655: files = list()
On 2011/06/16 15:48:59, kkania wrote:

> looks like this is never used; remove?

I think we need to hold file objects because the files will be deleted
on GC and cause error on send_keys().

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
chrome/test/webdriver/chromedriver_tests.py:656: filepaths = list()
On 2011/06/16 15:48:59, kkania wrote:

> list() -> [], everywhere used

Done.

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
chrome/test/webdriver/chromedriver_tests.py:668: path =
fileupload_single.value
On 2011/06/16 15:48:59, kkania wrote:

> value is supposed to be deprectated in the next release; how about
assert that
> the 'files' property has length 0 instead? Or I would be perfectly
fine with not
> doing any checks here

Done.

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
chrome/test/webdriver/chromedriver_tests.py:675: files = list()
On 2011/06/16 15:48:59, kkania wrote:

> looks like this is never used; remove?

Please see above.

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
chrome/test/webdriver/chromedriver_tests.py:690: path =
fileupload_multi.value.replace('\\', '//')
On 2011/06/16 15:48:59, kkania wrote:

> how about remove this and the next line (since it is covered later)

Done.

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
chrome/test/webdriver/chromedriver_tests.py:693: filesOnElement =
self._driver.execute_script(
On 2011/06/16 15:48:59, kkania wrote:

> files_on_element

Done.

http://codereview.chromium.org/7055004/diff/47001/chrome/test/webdriv...
chrome/test/webdriver/chromedriver_tests.py:699: self.assertTrue(name in
filenames)
On 2011/06/16 15:48:59, kkania wrote:

> remove name and use f['name'] directly

Done.

http://codereview.chromium.org/7055004/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Hisayori Noda  
View profile   Translate to Translated (View Original)
 More options Jun 27 2011, 12:22 am
From: Hisayori Noda <hn...@google.com>
Date: Mon, 27 Jun 2011 13:22:47 +0900
Local: Mon, Jun 27 2011 12:22 am
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author
I'm very sorry for late response. I had been forgotten to publish the comments.

2011年6月27日13:05  <hn...@google.com>:

--
Hisayori NODA

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Jun 27 2011, 6:18 pm
From: commit-...@chromium.org
Date: Mon, 27 Jun 2011 22:18:49 +0000
Local: Mon, Jun 27 2011 6:18 pm
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author
Presubmit check for 7055004-49005 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/common/notification_type.h,content/renderer/render_view.cc,content/ browser/renderer_host/render_view_host.cc,content/browser/renderer_host/ren der_view_host.h,content/common/drag_messages.h

Presubmit checks took 1.4s to calculate.

http://codereview.chromium.org/7055004/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
kka...@chromium.org  
View profile  
 More options Jun 27 2011, 7:16 pm
From: kka...@chromium.org
Date: Mon, 27 Jun 2011 23:16:08 +0000
Local: Mon, Jun 27 2011 7:16 pm
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author
adding jam for content/

http://codereview.chromium.org/7055004/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
j...@chromium.org  
View profile  
 More options Jun 27 2011, 7:36 pm
From: j...@chromium.org
Date: Mon, 27 Jun 2011 23:36:30 +0000
Local: Mon, Jun 27 2011 7:36 pm
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Jun 27 2011, 9:25 pm
From: commit-...@chromium.org
Date: Tue, 28 Jun 2011 01:25:23 +0000
Local: Mon, Jun 27 2011 9:25 pm
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author
Try job failure for 7055004-49005 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=wi...

http://codereview.chromium.org/7055004/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
hn...@google.com  
View profile  
 More options Jun 27 2011, 10:30 pm
From: hn...@google.com
Date: Tue, 28 Jun 2011 02:30:49 +0000
Local: Mon, Jun 27 2011 10:30 pm
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author
A member of Tokyo Chrome team (haraken@) confirmed that he can build
successfully.

http://codereview.chromium.org/7055004/diff/49005/chrome/test/webdriv...
File chrome/test/webdriver/commands/webelement_commands.cc (right):

http://codereview.chromium.org/7055004/diff/49005/chrome/test/webdriv...
chrome/test/webdriver/commands/webelement_commands.cc:586:
paths.push_back(path);
On 2011/06/28 00:58:38, kkania wrote:

> whoops, this won't work because path is a FilePath::StringType. I
think the
> nicest way to fix this would be to change the vector of strings to a
vector of
> file paths.

Done.

http://codereview.chromium.org/7055004/diff/49005/chrome/test/webdriv...
File chrome/test/webdriver/session.cc (right):

http://codereview.chromium.org/7055004/diff/49005/chrome/test/webdriv...
chrome/test/webdriver/session.cc:1288: Error*
Session::GetAttribute(const WebElementId& element,
On 2011/06/28 00:58:38, kkania wrote:

> these should be in the same order as in the .h file

Done.

http://codereview.chromium.org/7055004/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Jun 28 2011, 1:12 pm
From: commit-...@chromium.org
Date: Tue, 28 Jun 2011 17:12:00 +0000
Subject: Re: File upload API in chromedriver (issue7055004)
Print | Individual message | Show original | Find messages by this author
Change committed as 90785

http://codereview.chromium.org/7055004/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google