Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium-reviews
+ new post
About this group
Join this group
Added PAM configuration. (issue 11359043)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   7 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
jamiewa...@chromium.org  
View profile  
 More options Nov 2 2012, 2:30 pm
From: jamiewa...@chromium.org
Date: Fri, 02 Nov 2012 18:30:53 +0000
Local: Fri, Nov 2 2012 2:30 pm
Subject: Added PAM configuration. (issue 11359043)
Print | Individual message | Show original | Find messages by this author
Reviewers: Lambros,

Message:
ptal

Description:
Added PAM configuration.

BUG=159037

Please review this at https://codereview.chromium.org/11359043/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
   A remoting/host/installer/linux/debian/chrome-remote-desktop.pam

Index: remoting/host/installer/linux/debian/chrome-remote-desktop.pam
diff --git a/remoting/host/installer/linux/debian/chrome-remote-desktop.pam  
b/remoting/host/installer/linux/debian/chrome-remote-desktop.pam
new file mode 100644
index  
0000000000000000000000000000000000000000..7fa64c85f03b9d64cca3f0c6bbcd426bb e9c9beb
--- /dev/null
+++ b/remoting/host/installer/linux/debian/chrome-remote-desktop.pam
@@ -0,0 +1,6 @@
+# We fall back to the system default in /etc/pam.d/common-*
+
+@include common-auth
+@include common-account
+@include common-password
+@include common-session


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
lambroslamb...@chromium.org  
View profile  
 More options Nov 2 2012, 5:40 pm
From: lambroslamb...@chromium.org
Date: Fri, 02 Nov 2012 21:40:31 +0000
Local: Fri, Nov 2 2012 5:40 pm
Subject: Re: Added PAM configuration. (issue 11359043)
Print | Individual message | Show original | Find messages by this author
lgtm

http://codereview.chromium.org/11359043/diff/1/remoting/host/installe...
File remoting/host/installer/linux/debian/chrome-remote-desktop.pam
(right):

http://codereview.chromium.org/11359043/diff/1/remoting/host/installe...
remoting/host/installer/linux/debian/chrome-remote-desktop.pam:1: # We
fall back to the system default in /etc/pam.d/common-*
nit: Add copyright.
nit: End sentence with dot?
nit: plural "defaults"?
nit: Remove "We"?
I'm not sure this comment adds anything useful for the sys-admin, so I
think it's OK to remove it. As it is, the comment might convey the
message that it's a bad idea to edit this file.

http://codereview.chromium.org/11359043/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
jamiewa...@chromium.org  
View profile  
 More options Nov 2 2012, 8:45 pm
From: jamiewa...@chromium.org
Date: Sat, 03 Nov 2012 00:45:37 +0000
Local: Fri, Nov 2 2012 8:45 pm
Subject: Re: Added PAM configuration. (issue 11359043)
Print | Individual message | Show original | Find messages by this author
Done. The comment was essentially copied from pam.d/other, which is what  
this
file was based on. I agree it doesn't add anything. I've also added a  
copyright
notice.

https://codereview.chromium.org/11359043/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Nov 2 2012, 8:47 pm
From: commit-...@chromium.org
Date: Sat, 03 Nov 2012 00:47:10 +0000
Local: Fri, Nov 2 2012 8:47 pm
Subject: Re: Added PAM configuration. (issue 11359043)
Print | Individual message | Show original | Find messages by this author
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewa...@chromium.org/11359043/5001

https://chromiumcodereview.appspot.com/11359043/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Nov 3 2012, 12:24 am
From: commit-...@chromium.org
Date: Sat, 03 Nov 2012 04:24:39 +0000
Local: Sat, Nov 3 2012 12:24 am
Subject: Re: Added PAM configuration. (issue 11359043)
Print | Individual message | Show original | Find messages by this author
Retried try job too often for step(s) content_browsertests

https://chromiumcodereview.appspot.com/11359043/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Nov 3 2012, 3:15 am
From: commit-...@chromium.org
Date: Sat, 03 Nov 2012 07:15:11 +0000
Local: Sat, Nov 3 2012 3:15 am
Subject: Re: Added PAM configuration. (issue 11359043)
Print | Individual message | Show original | Find messages by this author
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewa...@chromium.org/11359043/5001

https://chromiumcodereview.appspot.com/11359043/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Nov 3 2012, 12:51 pm
From: commit-...@chromium.org
Date: Sat, 03 Nov 2012 16:51:16 +0000
Local: Sat, Nov 3 2012 12:51 pm
Subject: Re: Added PAM configuration. (issue 11359043)
Print | Individual message | Show original | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google