Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium-reviews
+ new post
About this group
Join this group
Extends IBusText to handle mozc's extended field. (issue 11363033)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   6 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
n...@chromium.org  
View profile  
 More options Nov 2 2012, 5:07 am
From: n...@chromium.org
Date: Fri, 02 Nov 2012 09:07:28 +0000
Local: Fri, Nov 2 2012 5:07 am
Subject: Extends IBusText to handle mozc's extended field. (issue 11363033)
Print | Individual message | Show original | Find messages by this author
Reviewers: satorux1,

Description:
Extends IBusText to handle mozc's extended field.

This is part of mozc dependency removal and libibus removal.

BUG=129403
TEST=ran chromeos_unittests

Please review this at http://codereview.chromium.org/11363033/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
   M chromeos/dbus/ibus/ibus_text.h
   M chromeos/dbus/ibus/ibus_text.cc
   M chromeos/dbus/ibus/ibus_text_unittest.cc


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sato...@chromium.org  
View profile  
 More options Nov 4 2012, 11:29 pm
From: sato...@chromium.org
Date: Mon, 05 Nov 2012 04:29:16 +0000
Local: Sun, Nov 4 2012 11:29 pm
Subject: Re: Extends IBusText to handle mozc's extended field. (issue 11363033)
Print | Individual message | Show original | Find messages by this author

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibu...
File chromeos/dbus/ibus/ibus_text.h (right):

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibu...
chromeos/dbus/ibus/ibus_text.h:144: std::string text() const { return
text_; }
const std::string& text()

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibu...
chromeos/dbus/ibus/ibus_text.h:147: std::string annotation() const {
return annotation_; }
ditto. please fix other places too.

http://codereview.chromium.org/11363033/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
n...@chromium.org  
View profile  
 More options Nov 5 2012, 12:27 am
From: n...@chromium.org
Date: Mon, 05 Nov 2012 05:27:42 +0000
Local: Mon, Nov 5 2012 12:27 am
Subject: Re: Extends IBusText to handle mozc's extended field. (issue 11363033)
Print | Individual message | Show original | Find messages by this author

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibu...
File chromeos/dbus/ibus/ibus_text.h (right):

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibu...
chromeos/dbus/ibus/ibus_text.h:144: std::string text() const { return
text_; }
On 2012/11/05 04:29:16, satorux1 wrote:

> const std::string& text()

Done.

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibu...
chromeos/dbus/ibus/ibus_text.h:147: std::string annotation() const {
return annotation_; }
On 2012/11/05 04:29:16, satorux1 wrote:

> ditto. please fix other places too.

Done.

http://codereview.chromium.org/11363033/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
sato...@chromium.org  
View profile  
 More options Nov 5 2012, 10:53 pm
From: sato...@chromium.org
Date: Tue, 06 Nov 2012 03:53:08 +0000
Local: Mon, Nov 5 2012 10:53 pm
Subject: Re: Extends IBusText to handle mozc's extended field. (issue 11363033)
Print | Individual message | Show original | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Nov 6 2012, 1:32 am
From: commit-...@chromium.org
Date: Tue, 06 Nov 2012 06:32:07 +0000
Local: Tues, Nov 6 2012 1:32 am
Subject: Re: Extends IBusText to handle mozc's extended field. (issue 11363033)
Print | Individual message | Show original | Find messages by this author
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/n...@chromium.org/11363033/5001

https://chromiumcodereview.appspot.com/11363033/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Nov 6 2012, 3:22 am
From: commit-...@chromium.org
Date: Tue, 06 Nov 2012 08:22:36 +0000
Local: Tues, Nov 6 2012 3:22 am
Subject: Re: Extends IBusText to handle mozc's extended field. (issue 11363033)
Print | Individual message | Show original | Find messages by this author

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google