Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium-reviews
+ new post
About this group
Join this group
Update policy presubmit chat after two policies were renamed (issue 11271018)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
bart...@chromium.org  
View profile  
 More options Oct 25 2012, 4:06 am
From: bart...@chromium.org
Date: Thu, 25 Oct 2012 08:06:39 +0000
Local: Thurs, Oct 25 2012 4:06 am
Subject: Update policy presubmit chat after two policies were renamed (issue 11271018)
Print | Individual message | Show original | Find messages by this author
Reviewers: Joao da Silva,

Message:
Hi Joao, could you please have a look?

Description:
Update policy presubmit chat after two policies were renamed

The policies related to Drive were renamed from GData* to Drive*. This
CL updates the policy presubmit check accordingly.

BUG=None

Please review this at https://codereview.chromium.org/11271018/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
   M chrome/app/policy/syntax_check_policy_template_json.py

Index: chrome/app/policy/syntax_check_policy_template_json.py
diff --git a/chrome/app/policy/syntax_check_policy_template_json.py  
b/chrome/app/policy/syntax_check_policy_template_json.py
index  
8cfcbb3d2bb9bed587b2742df882457b7e781b9a..a2d51952f49ad7fbc6d776bb5423723f2 bbaae12  
100755
--- a/chrome/app/policy/syntax_check_policy_template_json.py
+++ b/chrome/app/policy/syntax_check_policy_template_json.py
@@ -44,8 +44,8 @@ LEGACY_INVERTED_POLARITY_WHITELIST = [
      'DisableSpdy',
      'DisableSSLRecordSplitting',
      'ExternalStorageDisabled',
-    'GDataDisabled',
-    'GDataDisabledOverCellular',
+    'DriveDisabled',
+    'DriveDisabledOverCellular',
      'SavingBrowserHistoryDisabled',
      'SyncDisabled',
  ]


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
joaodasi...@chromium.org  
View profile  
 More options Oct 25 2012, 4:13 am
From: joaodasi...@chromium.org
Date: Thu, 25 Oct 2012 08:13:04 +0000
Local: Thurs, Oct 25 2012 4:13 am
Subject: Re: Update policy presubmit chat after two policies were renamed (issue 11271018)
Print | Individual message | Show original | Find messages by this author
lgtm

https://codereview.chromium.org/11271018/diff/1/chrome/app/policy/syn...
File chrome/app/policy/syntax_check_policy_template_json.py (right):

https://codereview.chromium.org/11271018/diff/1/chrome/app/policy/syn...
chrome/app/policy/syntax_check_policy_template_json.py:48:
'DriveDisabledOverCellular',
nit: alphabetical order

https://codereview.chromium.org/11271018/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
bart...@chromium.org  
View profile  
 More options Oct 25 2012, 4:14 am
From: bart...@chromium.org
Date: Thu, 25 Oct 2012 08:14:24 +0000
Local: Thurs, Oct 25 2012 4:14 am
Subject: Re: Update policy presubmit chat after two policies were renamed (issue 11271018)
Print | Individual message | Show original | Find messages by this author

https://chromiumcodereview.appspot.com/11271018/diff/1/chrome/app/pol...
File chrome/app/policy/syntax_check_policy_template_json.py (right):

https://chromiumcodereview.appspot.com/11271018/diff/1/chrome/app/pol...
chrome/app/policy/syntax_check_policy_template_json.py:48:
'DriveDisabledOverCellular',
On 2012/10/25 08:13:04, Joao da Silva wrote:

> nit: alphabetical order

Done.

https://chromiumcodereview.appspot.com/11271018/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Oct 25 2012, 4:14 am
From: commit-...@chromium.org
Date: Thu, 25 Oct 2012 08:14:58 +0000
Local: Thurs, Oct 25 2012 4:14 am
Subject: Re: Update policy presubmit chat after two policies were renamed (issue 11271018)
Print | Individual message | Show original | Find messages by this author
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bart...@chromium.org/11271018/5001

https://chromiumcodereview.appspot.com/11271018/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
commit-...@chromium.org  
View profile  
 More options Oct 25 2012, 5:15 am
From: commit-...@chromium.org
Date: Thu, 25 Oct 2012 09:15:55 +0000
Local: Thurs, Oct 25 2012 5:15 am
Subject: Re: Update policy presubmit chat after two policies were renamed (issue 11271018)
Print | Individual message | Show original | Find messages by this author
Retried try job too often for step(s) unit_tests

https://chromiumcodereview.appspot.com/11271018/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google