Re: Fix the issue of cursor being shown at startup. (issue 11364003)

ma...@chromium.org

unread,

Nov 19, 2012, 10:30:20 PM11/19/12

to de...@chromium.org, yos...@chromium.org, chromium...@chromium.org, sad...@chromium.org, ben+...@chromium.org

Sorry for this late reply.

I added tests and modified OpenAsh.
I noticed that cursor appeared to be hidden at startup without this CL after
http://src.chromium.org/viewvc/chrome?view=rev&revision=164452.
But ShowCursor(true) is still called in
MagnificationControllerImpl::OnImplicitAnimationsCompleted.
The reason why the cursor appeared to be hidden is that the cursor type is
set
to kCursorNone at that time.
In order to avoid this confusing behavior, I added code to initialize cursor
type to Shell::Init.

Please take another look.

http://codereview.chromium.org/11364003/diff/1/chrome/browser/ui/ash/ash_init.cc
File chrome/browser/ui/ash/ash_init.cc (right):

http://codereview.chromium.org/11364003/diff/1/chrome/browser/ui/ash/ash_init.cc#newcode61
chrome/browser/ui/ash/ash_init.cc:61:
ash::Shell::set_initially_hide_cursor(true);
On 2012/10/31 13:18:53, Daniel Erat wrote:
> Just to double-check, is it still shown as soon as the user moves the
mouse?
Yes, CompoundEventFilter::SetCursorVisibilityOnEvent will show the
cursor as soon as the user moves the mouse.

> I'm not sure that this is the right behavior. I think that most
developers run
> local builds in non-logged-in mode; it might be strange if the cursor
is always
> hidden when they do that. I think we really only want to hide it when
we're
> displaying the login screen or OOBE.
That's a good point. I changed the code to hide cursor only when
displaying the login screen if developer runs local builds on desktop.

http://codereview.chromium.org/11364003/