usb: use device tree to configure Exynos EHCI [chromiumos/third_party/u-boot : chromeos-v2011.12]

33 views
Skip to first unread message

Vincent Palatin (Code Review)

unread,
Nov 1, 2012, 6:58:03 PM11/1/12
to Vincent Palatin
Vincent Palatin has uploaded a new change for review.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................

usb: use device tree to configure Exynos EHCI

Read the EHCI controller parameters from the device tree.

Signed-off-by: Vincent Palatin <vpal...@chromium.org>

BRANCH=none
BUG=chrome-os-partner:14390
TEST=on Spring, boot from a USB stick plugged on the port 1 (HSIC hub)

Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
---
A doc/device-tree-bindings/usb/usb-ehci.txt
M drivers/usb/host/ehci-s5p.c
M include/fdtdec.h
M lib/fdtdec.c
4 files changed, 35 insertions(+), 1 deletion(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/u-boot refs/changes/51/37151/1
--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Jeremy Thorpe (Code Review)

unread,
Nov 1, 2012, 8:22:12 PM11/1/12
to Vincent Palatin, Gerrit, Simon Glass
Jeremy Thorpe has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 1: (1 inline comment)

Comments inline.

....................................................
File drivers/usb/host/ehci-s5p.c
Line 146: *port_bitmap = fdtdec_get_int(gd->fdt_blob, node, "port-bitmap",
I would prefer maybe:

ehci_hcor->bitmap = ...

or better:

ehci_hcor->disabled_ports = ...

This obviously depends on the previous CL.

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Jeremy Thorpe <jer...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Simon Glass (Code Review)

unread,
Nov 3, 2012, 4:58:08 PM11/3/12
to Vincent Palatin, Gerrit, Jeremy Thorpe
Simon Glass has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File doc/device-tree-bindings/usb/usb-ehci.txt
Line 10: - port-bitmap : defined which port should be enabled on the root hub.
port-enable-mask?

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Vincent Palatin (Code Review)

unread,
Nov 5, 2012, 1:19:37 PM11/5/12
to Vincent Palatin, Gerrit, Simon Glass, Jeremy Thorpe
Vincent Palatin has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File doc/device-tree-bindings/usb/usb-ehci.txt
Line 10: - port-bitmap : defined which port should be enabled on the root hub.
Done

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Jeremy Thorpe <jer...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>
Gerrit-Reviewer: Vincent Palatin <vpal...@chromium.org>

Vincent Palatin (Code Review)

unread,
Nov 5, 2012, 2:31:56 PM11/5/12
to Vincent Palatin, Gerrit, Simon Glass, Jeremy Thorpe
Vincent Palatin has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 3: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Simon Glass (Code Review)

unread,
Nov 5, 2012, 3:32:11 PM11/5/12
to Vincent Palatin, Gerrit, Jeremy Thorpe
Simon Glass has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File doc/device-tree-bindings/usb/usb-ehci.txt
Line 5: - compatible : should be "usb-ehci".
This binding does not fix with your example. Should this be a samsung-specific binding?

....................................................
File drivers/usb/host/ehci-s5p.c
Line 147: "port-enable-mask", 0xfffffff));
-1U?

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Vincent Palatin (Code Review)

unread,
Nov 5, 2012, 3:59:24 PM11/5/12
to Vincent Palatin, Gerrit, Simon Glass, Jeremy Thorpe
Vincent Palatin has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File doc/device-tree-bindings/usb/usb-ehci.txt
Line 5: - compatible : should be "usb-ehci".
why ?
the compatible property includes "usb-ehci"

....................................................
File drivers/usb/host/ehci-s5p.c
Line 147: "port-enable-mask", 0xfffffff));
Done

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Simon Glass (Code Review)

unread,
Nov 5, 2012, 5:27:19 PM11/5/12
to Vincent Palatin, Gerrit, Jeremy Thorpe
Simon Glass has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 4:

BTW please do remember the gen: tag before pushing

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Simon Glass (Code Review)

unread,
Nov 5, 2012, 5:28:35 PM11/5/12
to Vincent Palatin, Gerrit, Jeremy Thorpe
Simon Glass has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 4: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Jeremy Thorpe (Code Review)

unread,
Nov 5, 2012, 7:42:00 PM11/5/12
to Vincent Palatin, Gerrit, Simon Glass
Jeremy Thorpe has posted comments on this change.

Change subject: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

LGTM

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>

Vincent Palatin (Code Review)

unread,
Nov 5, 2012, 9:02:23 PM11/5/12
to Vincent Palatin, Gerrit, Simon Glass, Jeremy Thorpe
Vincent Palatin has posted comments on this change.

Change subject: gen: usb: use device tree to configure Exynos EHCI
......................................................................


Patch Set 5: Verified; Looks good to me, approved; Ready

Forwarding LGTM

--
To view, visit https://gerrit.chromium.org/gerrit/37151
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a02d32d9238d86e15cc4c4187667f71982d1f1
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Vincent Palatin <vpal...@chromium.org>
Reply all
Reply to author
Forward
0 new messages