faft: Move FAFT checkers to a separate module [chromiumos/third_party/autotest : master]
23 views
Skip to first unread message
Vic Yang (Code Review)
Oct 30, 2012, 9:48:58 PM10/30/12
to
Vic Yang has uploaded a new change for review.
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
faft: Move FAFT checkers to a separate module
BUG=chrome-os-partner:35902
TEST=Run FAFT suites and check they still work fine.
Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Signed-off-by: Vic Yang <victo...@chromium.org>
---
A server/cros/faft_checkers.py
M server/cros/faftsequence.py
M server/site_tests/firmware_CgptStress/firmware_CgptStress.py
M server/site_tests/firmware_ConsecutiveBoot/firmware_ConsecutiveBoot.py
M server/site_tests/firmware_CorruptBothFwBodyAB/firmware_CorruptBothFwBodyAB.py
M server/site_tests/firmware_CorruptBothFwSigAB/firmware_CorruptBothFwSigAB.py
M server/site_tests/firmware_CorruptBothKernelAB/firmware_CorruptBothKernelAB.py
M server/site_tests/firmware_CorruptFwBodyA/firmware_CorruptFwBodyA.py
M server/site_tests/firmware_CorruptFwBodyB/firmware_CorruptFwBodyB.py
M server/site_tests/firmware_CorruptFwSigA/firmware_CorruptFwSigA.py
M server/site_tests/firmware_CorruptFwSigB/firmware_CorruptFwSigB.py
M server/site_tests/firmware_CorruptKernelA/firmware_CorruptKernelA.py
M server/site_tests/firmware_CorruptKernelB/firmware_CorruptKernelB.py
M server/site_tests/firmware_DevBootUSB/firmware_DevBootUSB.py
M server/site_tests/firmware_DevFwNormalBoot/firmware_DevFwNormalBoot.py
M server/site_tests/firmware_DevMode/firmware_DevMode.py
M server/site_tests/firmware_DevModeStress/firmware_DevModeStress.py
M server/site_tests/firmware_DevScreenTimeout/firmware_DevScreenTimeout.py
M server/site_tests/firmware_DevTriggerRecovery/firmware_DevTriggerRecovery.py
M server/site_tests/firmware_ECBootTime/firmware_ECBootTime.py
M server/site_tests/firmware_ECWriteProtect/firmware_ECWriteProtect.py
M server/site_tests/firmware_FAFTSetup/firmware_FAFTSetup.py
M server/site_tests/firmware_FwScreenCloseLid/firmware_FwScreenCloseLid.py
M server/site_tests/firmware_FwScreenPressPower/firmware_FwScreenPressPower.py
M server/site_tests/firmware_InvalidUSB/firmware_InvalidUSB.py
M server/site_tests/firmware_RONormalBoot/firmware_RONormalBoot.py
M server/site_tests/firmware_RecoveryButton/firmware_RecoveryButton.py
M server/site_tests/firmware_RollbackFirmware/firmware_RollbackFirmware.py
M server/site_tests/firmware_RollbackKernel/firmware_RollbackKernel.py
M server/site_tests/firmware_ShellBall/firmware_ShellBall.py
M server/site_tests/firmware_SoftwareSync/firmware_SoftwareSync.py
M server/site_tests/firmware_TryFwB/firmware_TryFwB.py
M server/site_tests/firmware_UpdateECBin/firmware_UpdateECBin.py
M server/site_tests/firmware_UpdateFirmwareDataKeyVersion/firmware_UpdateFirmwareDataKeyVersion.py
M server/site_tests/firmware_UpdateFirmwareVersion/firmware_UpdateFirmwareVersion.py
M server/site_tests/firmware_UpdateKernelSubkeyVersion/firmware_UpdateKernelSubkeyVersion.py
M server/site_tests/firmware_UserRequestRecovery/firmware_UserRequestRecovery.py
37 files changed, 351 insertions(+), 329 deletions(-)
git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/89/36989/1
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
faft: Move FAFT checkers to a separate module
BUG=chrome-os-partner:35902
TEST=Run FAFT suites and check they still work fine.
Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Signed-off-by: Vic Yang <victo...@chromium.org>
---
A server/cros/faft_checkers.py
M server/cros/faftsequence.py
M server/site_tests/firmware_CgptStress/firmware_CgptStress.py
M server/site_tests/firmware_ConsecutiveBoot/firmware_ConsecutiveBoot.py
M server/site_tests/firmware_CorruptBothFwBodyAB/firmware_CorruptBothFwBodyAB.py
M server/site_tests/firmware_CorruptBothFwSigAB/firmware_CorruptBothFwSigAB.py
M server/site_tests/firmware_CorruptBothKernelAB/firmware_CorruptBothKernelAB.py
M server/site_tests/firmware_CorruptFwBodyA/firmware_CorruptFwBodyA.py
M server/site_tests/firmware_CorruptFwBodyB/firmware_CorruptFwBodyB.py
M server/site_tests/firmware_CorruptFwSigA/firmware_CorruptFwSigA.py
M server/site_tests/firmware_CorruptFwSigB/firmware_CorruptFwSigB.py
M server/site_tests/firmware_CorruptKernelA/firmware_CorruptKernelA.py
M server/site_tests/firmware_CorruptKernelB/firmware_CorruptKernelB.py
M server/site_tests/firmware_DevBootUSB/firmware_DevBootUSB.py
M server/site_tests/firmware_DevFwNormalBoot/firmware_DevFwNormalBoot.py
M server/site_tests/firmware_DevMode/firmware_DevMode.py
M server/site_tests/firmware_DevModeStress/firmware_DevModeStress.py
M server/site_tests/firmware_DevScreenTimeout/firmware_DevScreenTimeout.py
M server/site_tests/firmware_DevTriggerRecovery/firmware_DevTriggerRecovery.py
M server/site_tests/firmware_ECBootTime/firmware_ECBootTime.py
M server/site_tests/firmware_ECWriteProtect/firmware_ECWriteProtect.py
M server/site_tests/firmware_FAFTSetup/firmware_FAFTSetup.py
M server/site_tests/firmware_FwScreenCloseLid/firmware_FwScreenCloseLid.py
M server/site_tests/firmware_FwScreenPressPower/firmware_FwScreenPressPower.py
M server/site_tests/firmware_InvalidUSB/firmware_InvalidUSB.py
M server/site_tests/firmware_RONormalBoot/firmware_RONormalBoot.py
M server/site_tests/firmware_RecoveryButton/firmware_RecoveryButton.py
M server/site_tests/firmware_RollbackFirmware/firmware_RollbackFirmware.py
M server/site_tests/firmware_RollbackKernel/firmware_RollbackKernel.py
M server/site_tests/firmware_ShellBall/firmware_ShellBall.py
M server/site_tests/firmware_SoftwareSync/firmware_SoftwareSync.py
M server/site_tests/firmware_TryFwB/firmware_TryFwB.py
M server/site_tests/firmware_UpdateECBin/firmware_UpdateECBin.py
M server/site_tests/firmware_UpdateFirmwareDataKeyVersion/firmware_UpdateFirmwareDataKeyVersion.py
M server/site_tests/firmware_UpdateFirmwareVersion/firmware_UpdateFirmwareVersion.py
M server/site_tests/firmware_UpdateKernelSubkeyVersion/firmware_UpdateKernelSubkeyVersion.py
M server/site_tests/firmware_UserRequestRecovery/firmware_UserRequestRecovery.py
37 files changed, 351 insertions(+), 329 deletions(-)
git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/89/36989/1
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Tom Wai-Hong Tam (Code Review)
Oct 31, 2012, 2:26:00 AM10/31/12
to Vic Yang, Gerrit, Mike Truty, Vadim Bendebury
Tom Wai-Hong Tam has posted comments on this change.
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(4 inline comments)
....................................................
File server/cros/faft_checkers.py
Line 1: # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
2012
Line 16: """Constructor."""
Don't need the comment for this well-known method.
Line 17: self.faftsequence = faftsequence
It is only used once for the ROOTFS_MAP. Actually it is not necessary. You can define here in order to reduce dependency.
Line 18: self.servo = servo
It isn't used. Better to remove it to reduce dependency.
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
(4 inline comments)
....................................................
File server/cros/faft_checkers.py
Line 1: # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
2012
Line 16: """Constructor."""
Don't need the comment for this well-known method.
Line 17: self.faftsequence = faftsequence
It is only used once for the ROOTFS_MAP. Actually it is not necessary. You can define here in order to reduce dependency.
Line 18: self.servo = servo
It isn't used. Better to remove it to reduce dependency.
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Vic Yang (Code Review)
Oct 31, 2012, 6:41:14 AM10/31/12
to Gerrit, Mike Truty, Vadim Bendebury, Tom Wai-Hong Tam
Vic Yang has posted comments on this change.
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File server/cros/faft_checkers.py
Line 1: # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
Done
Line 16: """Constructor."""
Done
Line 17: self.faftsequence = faftsequence
It is also used in faftsequence.check_ec_capability().
Line 18: self.servo = servo
Done
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
....................................................
File server/cros/faft_checkers.py
Line 1: # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
Line 16: """Constructor."""
Done
Line 17: self.faftsequence = faftsequence
Line 18: self.servo = servo
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Gerrit-Reviewer: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Tom Wai-Hong Tam (Code Review)
Oct 31, 2012, 7:19:01 AM10/31/12
to Vic Yang, Gerrit, Mike Truty, Vadim Bendebury
Tom Wai-Hong Tam has posted comments on this change.
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Vic Yang (Code Review)
Oct 31, 2012, 8:01:47 AM10/31/12
to Gerrit, Mike Truty, Vadim Bendebury, Tom Wai-Hong Tam
Vic Yang has posted comments on this change.
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
Patch Set 3: Verified; Ready
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Vic Yang (Code Review)
Oct 31, 2012, 8:07:26 AM10/31/12
to Gerrit, Mike Truty, Vadim Bendebury, Tom Wai-Hong Tam
Vic Yang has posted comments on this change.
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Vic Yang (Code Review)
Oct 31, 2012, 10:09:22 PM10/31/12
to Gerrit, Mike Truty, Vadim Bendebury, Tom Wai-Hong Tam
Vic Yang has posted comments on this change.
Change subject: faft: Move FAFT checkers to a separate module
......................................................................
Patch Set 3: Ready
......................................................................
--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Reply all
Reply to author
Forward
0 new messages