Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
Message from discussion faft: Move FAFT checkers to a separate module [chromiumos/third_party/autote st : master]
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Tom Wai-Hong Tam (Code Review)  
View profile  
 More options Oct 31 2012, 2:26 am
From: "Tom Wai-Hong Tam (Code Review)" <ger...@chromium.org>
Date: Tue, 30 Oct 2012 23:26:00 -0700
Subject: faft: Move FAFT checkers to a separate module [chromiumos/third_party/autotest : master]
Print | View thread | Show original | Find messages by this author
Tom Wai-Hong Tam has posted comments on this change.

Change subject: faft: Move FAFT checkers to a separate module
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(4 inline comments)

....................................................
File server/cros/faft_checkers.py
Line 1: # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
2012

Line 16:         """Constructor."""
Don't need the comment for this well-known method.

Line 17:         self.faftsequence = faftsequence
It is only used once for the ROOTFS_MAP. Actually it is not necessary. You can define here in order to reduce dependency.

Line 18:         self.servo = servo
It isn't used. Better to remove it to reduce dependency.

--
To view, visit https://gerrit.chromium.org/gerrit/36989
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victory...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <waih...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vben...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google