shill: l2tpipsec: Cleanup on disconnect. [chromiumos/platform/shill : master]

15 views
Skip to first unread message

Darin Petkov (Code Review)

unread,
Nov 14, 2012, 8:11:50 AM11/14/12
to Darin Petkov
Darin Petkov has uploaded a new change for review.

Change subject: shill: l2tpipsec: Cleanup on disconnect.
......................................................................

shill: l2tpipsec: Cleanup on disconnect.

Previously, we would mark the service as disconnected but we would
leave a bunch of resources around such as the l2tpipsec_manager
process.

BUG=chromium-os:36095
TEST=unit tests; established l2tp/ipsec, shut down server, checked
that shill disconnects right away and shuts down l2tpipsec_vpn and
pppd on the client.

Change-Id: I729eac375ca2229311decd52e20acfa4332e2a59
---
M l2tp_ipsec_driver.cc
M l2tp_ipsec_driver.h
M l2tp_ipsec_driver_unittest.cc
M rpc_task.cc
4 files changed, 58 insertions(+), 8 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/shill refs/changes/19/38019/1
--
To view, visit https://gerrit.chromium.org/gerrit/38019
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I729eac375ca2229311decd52e20acfa4332e2a59
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>

Darin Petkov (Code Review)

unread,
Nov 14, 2012, 8:13:22 AM11/14/12
to Darin Petkov, Gerrit, Ben Chan, Paul Stewart
Darin Petkov has posted comments on this change.

Change subject: shill: l2tpipsec: Cleanup on disconnect.
......................................................................


Patch Set 1: Verified

PTAL

--
To view, visit https://gerrit.chromium.org/gerrit/38019
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I729eac375ca2229311decd52e20acfa4332e2a59
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>
Gerrit-Reviewer: Ben Chan <ben...@chromium.org>
Gerrit-Reviewer: Darin Petkov <pet...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
Nov 14, 2012, 11:26:36 AM11/14/12
to Darin Petkov, Gerrit, Ben Chan
Paul Stewart has posted comments on this change.

Change subject: shill: l2tpipsec: Cleanup on disconnect.
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/38019
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I729eac375ca2229311decd52e20acfa4332e2a59
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>

Darin Petkov (Code Review)

unread,
Nov 15, 2012, 3:29:55 AM11/15/12
to Darin Petkov, Gerrit, Ben Chan, Paul Stewart
Darin Petkov has posted comments on this change.

Change subject: shill: l2tpipsec: Cleanup on disconnect.
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/38019
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I729eac375ca2229311decd52e20acfa4332e2a59
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>
Reply all
Reply to author
Forward
0 new messages