shill: Add missing documentation for the default service man... [chromiumos/platform/shill : master]

14 views
Skip to first unread message

Gaurav Shah (Code Review)

unread,
Nov 5, 2012, 9:04:48 PM11/5/12
to Gaurav Shah
Gaurav Shah has uploaded a new change for review.

Change subject: shill: Add missing documentation for the default service manager property
......................................................................

shill: Add missing documentation for the default service manager property

BUG=none
TEST=none

Change-Id: I411b4b46fb43a6084dfc64d5bb367f57c991c8f4
---
M doc/manager-api.txt
1 file changed, 4 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/shill refs/changes/05/37405/1
--
To view, visit https://gerrit.chromium.org/gerrit/37405
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I411b4b46fb43a6084dfc64d5bb367f57c991c8f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Gaurav Shah <gaur...@chromium.org>

mukesh agrawal (Code Review)

unread,
Nov 5, 2012, 9:07:43 PM11/5/12
to Gaurav Shah, Gerrit
mukesh agrawal has posted comments on this change.

Change subject: shill: Add missing documentation for the default service manager property
......................................................................


Patch Set 1: Looks good to me, approved

thanks

--
To view, visit https://gerrit.chromium.org/gerrit/37405
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I411b4b46fb43a6084dfc64d5bb367f57c991c8f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Gaurav Shah <gaur...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

Gaurav Shah (Code Review)

unread,
Nov 5, 2012, 9:19:00 PM11/5/12
to Gaurav Shah, Gerrit, mukesh agrawal
Gaurav Shah has posted comments on this change.

Change subject: shill: Add missing documentation for the default service manager property
......................................................................


Patch Set 1: Verified; Looks good to me, approved

chumping, just a documentation change.

--
To view, visit https://gerrit.chromium.org/gerrit/37405
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I411b4b46fb43a6084dfc64d5bb367f57c991c8f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Gaurav Shah <gaur...@chromium.org>
Gerrit-Reviewer: Gaurav Shah <gaur...@chromium.org>

Gaurav Shah (Code Review)

unread,
Nov 5, 2012, 9:19:00 PM11/5/12
to Gaurav Shah, Gerrit, mukesh agrawal
Gaurav Shah has submitted this change and it was merged.

Change subject: shill: Add missing documentation for the default service manager property
......................................................................


shill: Add missing documentation for the default service manager property

BUG=none
TEST=none

Change-Id: I411b4b46fb43a6084dfc64d5bb367f57c991c8f4
---
M doc/manager-api.txt
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
Gaurav Shah: Verified; Looks good to me, approved
mukesh agrawal: Looks good to me, approved


--
To view, visit https://gerrit.chromium.org/gerrit/37405
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I411b4b46fb43a6084dfc64d5bb367f57c991c8f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Gaurav Shah <gaur...@chromium.org>
Reply all
Reply to author
Forward
0 new messages