Received: by 10.52.18.203 with SMTP id y11mr3496331vdd.6.1352162689426;
        Mon, 05 Nov 2012 16:44:49 -0800 (PST)
X-BeenThere: chromium-os-revi...@chromium.org
Received: by 10.52.16.79 with SMTP id e15ls6144951vdd.6.gmail; Mon, 05 Nov
 2012 16:44:48 -0800 (PST)
Received: by 10.52.95.237 with SMTP id dn13mr9783353vdb.83.1352162688763;
        Mon, 05 Nov 2012 16:44:48 -0800 (PST)
Received: by 10.52.95.237 with SMTP id dn13mr9783352vdb.83.1352162688751;
        Mon, 05 Nov 2012 16:44:48 -0800 (PST)
Return-Path: <ger...@chromium.org>
Received: from ns1.golo.chromium.org (postal.chromium.org [74.125.248.75])
        by mx.google.com with ESMTP id l17si10334693vcu.57.2012.11.05.16.44.48;
        Mon, 05 Nov 2012 16:44:48 -0800 (PST)
Received-SPF: pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) client-ip=74.125.248.75;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) smtp.mail=ger...@chromium.org
Message-Id: <50985d80.518ddc0a.1df8.ffff994cSMTPIN_ADDED@mx.google.com>
Received: from 192.168.20.14 (gerrit.golo.chromium.org [192.168.20.14])
	by ns1.golo.chromium.org (Postfix) with ESMTP id 9F757162670;
	Mon,  5 Nov 2012 16:44:48 -0800 (PST)
Date: Mon, 5 Nov 2012 16:44:48 -0800
From: "David James (Code Review)" <ger...@chromium.org>
To: Mike Frysinger <vap...@chromium.org>
CC: Gerrit <chrome-...@google.com>
Reply-To: davidja...@chromium.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?tar:_update_to_latest_upstream_version_[chromiumos/overlays/portage-stable_:_master]=0A?=
X-Gerrit-Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
Mailing-List: list gerrit-chromiumos-overlays-portage-sta...@gerrit.chromium.org
List-Id: <gerrit-chromiumos-overlays-portage-stable.gerrit.chromium.org>
List-Unsubscribe: <https://gerrit.chromium.org/gerrit/settings>
X-Gerrit-ChangeURL: <https://gerrit.chromium.org/gerrit/37380>
X-Gerrit-Commit: 35c6fa5793ac4d955e728da20f9c4ebf2c7b4923
In-Reply-To: <gerrit.1352153941847.I65f9bec4491f1ed82707bebba753276594f66...@gerrit.chromium.org>
References: <gerrit.1352153941847.I65f9bec4491f1ed82707bebba753276594f66...@gerrit.chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.4.2

David James has posted comments on this change.

Change subject: tar: update to latest upstream version
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File app-arch/tar/tar-1.26-r1.ebuild
Line 73: 			-type f -a '!' -name tar -delete
Shouldn't this have the ${p} in here? Otherwise, in the case where userland_GNU is disabled, minimal will be really minimal and delete 'gtar' as well :)

--
To view, visit https://gerrit.chromium.org/gerrit/37380
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>