tar: update to latest upstream version [chromiumos/overlays/portage-stable : master]

21 views
Skip to first unread message

Mike Frysinger (Code Review)

unread,
Nov 5, 2012, 5:19:02 PM11/5/12
to David James, Mike Frysinger
Hello David James,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/37380

to review the following change.

Change subject: tar: update to latest upstream version
......................................................................

tar: update to latest upstream version

This version includes USE=minimal support which strips down the install.

BUG=chromium-os:22939
TEST=`cbuildbot x86-generic-full` works
TEST=`cbuildbot chromiumos-sdk` works

Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
---
M app-arch/tar/Manifest
D app-arch/tar/files/tar-1.21-revert-pipe.patch
D app-arch/tar/files/tar-1.21-testsuite.patch
D app-arch/tar/files/tar-1.22-strncpy.patch
D app-arch/tar/files/tar-1.23-revert-pipe.patch
D app-arch/tar/files/tar-1.23-strncpy.patch
D app-arch/tar/files/tar-1.23-symlink-k-hang.patch
D app-arch/tar/files/tar-1.23-tests.patch
A app-arch/tar/files/tar-1.26-no-gets.patch
A app-arch/tar/files/tar-1.26-xattr.patch
D app-arch/tar/tar-1.23-r4.ebuild
A app-arch/tar/tar-1.26-r1.ebuild
12 files changed, 1,029 insertions(+), 724 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/portage-stable refs/changes/80/37380/1
--
To view, visit https://gerrit.chromium.org/gerrit/37380
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>

David James (Code Review)

unread,
Nov 5, 2012, 7:44:48 PM11/5/12
to Mike Frysinger, Gerrit
David James has posted comments on this change.

Change subject: tar: update to latest upstream version
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File app-arch/tar/tar-1.26-r1.ebuild
Line 73: -type f -a '!' -name tar -delete
Shouldn't this have the ${p} in here? Otherwise, in the case where userland_GNU is disabled, minimal will be really minimal and delete 'gtar' as well :)

--
To view, visit https://gerrit.chromium.org/gerrit/37380
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>

Mike Frysinger (Code Review)

unread,
Nov 5, 2012, 10:10:41 PM11/5/12
to Mike Frysinger, Gerrit, David James
Mike Frysinger has posted comments on this change.

Change subject: tar: update to latest upstream version
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File app-arch/tar/tar-1.26-r1.ebuild
Line 73: -type f -a '!' -name tar -delete
true ... i'll get that fixed up

--
To view, visit https://gerrit.chromium.org/gerrit/37380
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

David James (Code Review)

unread,
Nov 5, 2012, 11:51:14 PM11/5/12
to Mike Frysinger, Gerrit
David James has posted comments on this change.

Change subject: tar: update to latest upstream version
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37380
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>

Mike Frysinger (Code Review)

unread,
Nov 6, 2012, 12:41:22 AM11/6/12
to Mike Frysinger, Gerrit, David James
Mike Frysinger has posted comments on this change.

Change subject: tar: update to latest upstream version
......................................................................


Patch Set 2: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/37380
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65f9bec4491f1ed82707bebba753276594f66e29
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Reply all
Reply to author
Forward
0 new messages