Received: by 10.224.189.16 with SMTP id dc16mr16469231qab.0.1351661920857;
        Tue, 30 Oct 2012 22:38:40 -0700 (PDT)
X-BeenThere: chromium-os-revi...@chromium.org
Received: by 10.229.171.224 with SMTP id i32ls1648478qcz.8.gmail; Tue, 30 Oct
 2012 22:38:40 -0700 (PDT)
Received: by 10.224.70.140 with SMTP id d12mr17314974qaj.53.1351661920012;
        Tue, 30 Oct 2012 22:38:40 -0700 (PDT)
Received: by 10.224.70.140 with SMTP id d12mr17314973qaj.53.1351661919998;
        Tue, 30 Oct 2012 22:38:39 -0700 (PDT)
Return-Path: <ger...@chromium.org>
Received: from ns1.golo.chromium.org (postal.chromium.org [74.125.248.75])
        by mx.google.com with ESMTP id ku8si2068942qeb.16.2012.10.30.22.38.39;
        Tue, 30 Oct 2012 22:38:39 -0700 (PDT)
Received-SPF: pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) client-ip=74.125.248.75;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) smtp.mail=ger...@chromium.org
Message-Id: <5090b95f.8877310a.790e.ffffc5e0SMTPIN_ADDED@mx.google.com>
Received: from 192.168.20.14 (gerrit.golo.chromium.org [192.168.20.14])
	by ns1.golo.chromium.org (Postfix) with ESMTP id C1C43161556;
	Tue, 30 Oct 2012 22:38:39 -0700 (PDT)
Date: Tue, 30 Oct 2012 22:38:39 -0700
From: "Chung-yih Wang (Code Review)" <ger...@chromium.org>
CC: Gerrit <chrome-...@google.com>,
	Daniel Kurtz <djku...@chromium.org>,
	Andrew de los Reyes <a...@chromium.org>
Reply-To: cyw...@chromium.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?x11-drivers/xf86-input-evdev:_Add_SYN=5FDROPPED_handling_[chromiumos/overlays/chromiumos-overlay_:_master]=0A?=
X-Gerrit-Change-Id: Ia5b2eda0438152ead497e8c4f0053cd5a1f6a40c
Mailing-List: list gerrit-chromiumos-overlays-chromiumos-over...@gerrit.chromium.org
List-Id: <gerrit-chromiumos-overlays-chromiumos-overlay.gerrit.chromium.org>
List-Unsubscribe: <https://gerrit.chromium.org/gerrit/settings>
X-Gerrit-ChangeURL: <https://gerrit.chromium.org/gerrit/36906>
X-Gerrit-Commit: d9ceb52de697e04f6c46c2e9ced2115ea6c7df2c
In-Reply-To: <gerrit.1351614229172.Ia5b2eda0438152ead497e8c4f0053cd5a1f6a...@gerrit.chromium.org>
References: <gerrit.1351614229172.Ia5b2eda0438152ead497e8c4f0053cd5a1f6a...@gerrit.chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.4.2

Chung-yih Wang has posted comments on this change.

Change subject: x11-drivers/xf86-input-evdev: Add SYN_DROPPED handling
......................................................................


Patch Set 2:

* can we get this upstream after it goes in here?
=> Yes, but we also need to upstream the 'Use monotonic clock' patch as well.

* when using our evdev logging (from .../third_party/chromiumos-overlay/x11-drivers/xf86-input-evdev/files/evdev-2.7.0-feedback-log.patch), do we still get the SYN_DROPPED message in the log? It would be good to make sure the log matches exactly what we get from the kernel.

=> Yes, we will get the SYN_DROPPED message in the log. But this will be a slightly different from what we read from kernel after SYN_DROPPED is received as we need to make the state consistent, so we will drain the queue until the state sync is atomic.

--
To view, visit https://gerrit.chromium.org/gerrit/36906
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5b2eda0438152ead497e8c4f0053cd5a1f6a40c
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>
Gerrit-Reviewer: Andrew de los Reyes <a...@chromium.org>
Gerrit-Reviewer: Chung-yih Wang <cyw...@chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djku...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>