Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Message from discussion Modify EnterpriseUITest autotests to attempt to clear the TP... [chromiumos/third_party/autote st : master]
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Nirnimesh (Code Review)  
View profile  
 More options May 4 2012, 9:16 pm
From: "Nirnimesh (Code Review)" <ger...@chromium.org>
Date: Fri, 4 May 2012 18:16:57 -0700
Local: Fri, May 4 2012 9:16 pm
Subject: Modify EnterpriseUITest autotests to attempt to clear the TP... [chromiumos/third_party/autotest : master]
Nirnimesh has posted comments on this change.

Change subject: Modify EnterpriseUITest autotests to attempt to clear the TPM if owned on test initialization.
......................................................................

Patch Set 2: (5 inline comments)

Stupid gerrit. It posted my reply to the other patchset, which did not have comments.

....................................................
File client/cros/enterprise_ui_test.py
Line 93:         try:
do not do try/catch. Just check if the file exists and act accordingly.

Line 94:             with open(self._TPM_PASSWORD_FILE, 'r') as passwd_file:
'r' is redundant

Line 159:         self.job.set_state('client_state', 'RETRY')
maybe call it 'REBOOT'

....................................................
File server/site_tests/desktopui_EnterprisePolicyServer/control
Line 21: #    ('test_prod_enterprise_executive_user', {'prod': True}),
remove

....................................................
File server/site_tests/desktopui_EnterprisePolicyServer/desktopui_EnterprisePoli cyServer.py
Line 55:         if not self.job.get_state('client_state') == 'SUCCESS':
remove 'not' and use !=

--
To view, visit https://gerrit.chromium.org/gerrit/21815
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d053b09f9f823b5d7d017275ba346d5b0180492
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Craig Harrison <crai...@chromium.org>
Gerrit-Reviewer: Bartosz Fabianowski <bart...@chromium.org>
Gerrit-Reviewer: Craig Harrison <crai...@chromium.org>
Gerrit-Reviewer: Nirnimesh <nirnim...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.