UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]

29 views
Skip to first unread message

Dylan Reid (Code Review)

unread,
Apr 20, 2012, 2:31:57 PM4/20/12
to Olof Johansson, Mandeep Singh Baines
Dylan Reid has uploaded a new change for review.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

UPSTREAM: ALSA: Introduce common helper functions for jack-detection control

Now move the helper function for creating and reporting the jack-detection
to the common place. The driver that needs this functionality should
select CONFIG_SND_KCTL_JACK kconfig.

BUG=chromium-os:20620
TEST=Manual, run kernel on stumpy and check for JACK controls.

Signed-off-by: Takashi Iwai <ti...@suse.de>
(cherry picked from commit 35be544af367170a9c6bf63adcf9d0cb2d569dbb)
Signed-off-by: Dylan Reid <dgr...@chromium.org>

Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
---
M include/sound/control.h
M sound/core/Kconfig
M sound/core/Makefile
A sound/core/ctljack.c
M sound/pci/hda/Kconfig
M sound/pci/hda/hda_jack.c
M sound/pci/hda/hda_jack.h
7 files changed, 76 insertions(+), 49 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/18/20718/1
--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Todd Broch (Code Review)

unread,
Apr 26, 2012, 4:13:14 PM4/26/12
to Dylan Reid, Taylor Hutt
Todd Broch has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 26, 2012, 9:28:14 PM4/26/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 26, 2012, 11:44:01 PM4/26/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 3: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 1:02:03 AM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 4: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 1:48:12 AM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 5: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 2:24:00 AM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 5: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 4:31:13 AM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 6: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 11:38:28 AM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 6: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 4:26:18 PM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................


Patch Set 8: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 8
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Reply all
Reply to author
Forward
0 new messages