firmware_ECThermal: stop userspace thermal loop before testi... [chromiumos/third_party/autotest : master]

16 views
Skip to first unread message

Vic Yang (Code Review)

unread,
Oct 30, 2012, 9:16:31 AM10/30/12
to
Vic Yang has uploaded a new change for review.

Change subject: firmware_ECThermal: stop userspace thermal loop before testing
......................................................................

firmware_ECThermal: stop userspace thermal loop before testing

Userspace thermal loop interferes with EC internal thermal loop. Let's
disable it before testing.

BUG=chrome-os-partner:11714
TEST=Test passed. See 'Stopped temp_metrics' in the log.

Change-Id: Ibc6c8c026319c38799d291e0960d6c71ba9534b0
Signed-off-by: Vic Yang <victo...@chromium.org>
---
M server/site_tests/firmware_ECThermal/firmware_ECThermal.py
1 file changed, 10 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/95/36895/1
--
To view, visit https://gerrit.chromium.org/gerrit/36895
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc6c8c026319c38799d291e0960d6c71ba9534b0
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>

Mike Truty (Code Review)

unread,
Oct 30, 2012, 11:24:45 AM10/30/12
to Vic Yang, Gerrit, Mike Truty, Tom Wai-Hong Tam, Grant Grundler
Mike Truty has posted comments on this change.

Change subject: firmware_ECThermal: stop userspace thermal loop before testing
......................................................................


Patch Set 2:

added grundler for fyi

--
To view, visit https://gerrit.chromium.org/gerrit/36895
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc6c8c026319c38799d291e0960d6c71ba9534b0
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vic Yang <victo...@chromium.org>

Tom Wai-Hong Tam (Code Review)

unread,
Oct 31, 2012, 2:42:55 AM10/31/12
to Vic Yang, Gerrit, Mike Truty, Grant Grundler
Tom Wai-Hong Tam has posted comments on this change.

Change subject: firmware_ECThermal: stop userspace thermal loop before testing
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/36895
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc6c8c026319c38799d291e0960d6c71ba9534b0
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>

Vic Yang (Code Review)

unread,
Oct 31, 2012, 2:44:51 AM10/31/12
to Gerrit, Mike Truty, Tom Wai-Hong Tam, Grant Grundler
Vic Yang has posted comments on this change.

Change subject: firmware_ECThermal: stop userspace thermal loop before testing
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/36895
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc6c8c026319c38799d291e0960d6c71ba9534b0
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>

Vic Yang (Code Review)

unread,
Oct 31, 2012, 6:45:03 AM10/31/12
to Gerrit, Mike Truty, Tom Wai-Hong Tam, Grant Grundler
Vic Yang has posted comments on this change.

Change subject: firmware_ECThermal: stop userspace thermal loop before testing
......................................................................


Patch Set 2: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/36895
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc6c8c026319c38799d291e0960d6c71ba9534b0
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>

Vic Yang (Code Review)

unread,
Oct 31, 2012, 10:09:15 PM10/31/12
to Gerrit, Mike Truty, Tom Wai-Hong Tam
Vic Yang has posted comments on this change.

Change subject: firmware_ECThermal: stop userspace thermal loop before testing
......................................................................


Patch Set 2: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/36895
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc6c8c026319c38799d291e0960d6c71ba9534b0
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Reply all
Reply to author
Forward
0 new messages