Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]

58 views
Skip to first unread message

Jon Salz (Code Review)

unread,
Apr 25, 2012, 2:17:06 PM4/25/12
to
Jon Salz has uploaded a new change for review.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Build static directory (containing JS/CSS for factory UI).

BUG=None
TEST=Build and run

Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
---
M chromeos-base/autotest/autotest-9999.ebuild
1 file changed, 2 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/67/21067/1
--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Chris Sosa (Code Review)

unread,
Apr 25, 2012, 6:53:28 PM4/25/12
to Jon Salz, Zdenek Behan, Scott Zawalski
Chris Sosa has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Adding scottz:

Scott - while usually deps is the way we'd want to package an outside dependency into autotest, it seems for factory since they want the entire autotest blob than this might be the best approach. Any comments?

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52: dev-lang/closure-compiler-bin
Do we know how big this is?

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>

Jon Salz (Code Review)

unread,
Apr 25, 2012, 7:00:46 PM4/25/12
to Zdenek Behan, Chris Sosa, Scott Zawalski
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: (1 inline comment)

Also note that this is a fairly special kind of dep - it is not ever used by an autotest directly (at runtime); it's just used at compile time.

Also worth noting that we are planning on the factory test harness, including the UI, out of autotest: the fact that it is in autotest is sort of an artifact of a previous implementation. At that point we will also be reverting the autotest-9999.ebuild changes, of course, and removing the Closure library archive from the autotest tree.

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52: dev-lang/closure-compiler-bin
5.2MB. However, it also requires the IcedTea JRE, which is ~113MB unpacked or ~35MB packed. We've discussed this in the "Using Google Closure library for our UI" thread on chromeos-build, and it seems like the consensus is that it's OK to include it. (It's necessary for serious JavaScript development, and in fact other projects in ChromiumOS are already using it; they just haven't added it to the chroot.)

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Mike Frysinger (Code Review)

unread,
Apr 25, 2012, 7:01:43 PM4/25/12
to Jon Salz, Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52: dev-lang/closure-compiler-bin
this pkg itself is small. but it pulls in a jre ;).

$ qsize java closure
dev-lang/closure-compiler-bin-20120305: 4 files, 9 non-files, 5255.501 KB
dev-java/icedtea6-bin-1.6.2-r2: 689 files, 53 non-files, 113562.482 KB
dev-java/java-config-2.1.10: 78 files, 30 non-files, 136.458 KB
dev-java/java-config-wrapper-0.16: 4 files, 5 non-files, 17.194 KB

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

Scott Zawalski (Code Review)

unread,
Apr 25, 2012, 8:19:58 PM4/25/12
to Jon Salz, Zdenek Behan, Chris Sosa, Mike Frysinger
Scott Zawalski has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

Since we want the whole blob this is going to be the best way.

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
Apr 26, 2012, 10:52:13 AM4/26/12
to Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Chris Sosa (Code Review)

unread,
Apr 26, 2012, 4:07:37 PM4/26/12
to Jon Salz, Zdenek Behan, Scott Zawalski, Mike Frysinger
Chris Sosa has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
Apr 26, 2012, 4:09:25 PM4/26/12
to Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
Apr 26, 2012, 4:26:16 PM4/26/12
to Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3:

Ha, oops, I confused this with the Makefile change (which is obviously necessary before this one). God Bless CQ

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
May 3, 2012, 4:37:36 PM5/3/12
to Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
May 3, 2012, 4:59:11 PM5/3/12
to Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 4: Verified; Looks good to me, approved; Ready

Rebased, self+2-ing

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
May 3, 2012, 9:39:39 PM5/3/12
to Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 4: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
May 3, 2012, 10:16:08 PM5/3/12
to Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 5: Verified; Looks good to me, approved; Ready

Re-rebased, +2ing

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 4, 2012, 4:54:55 PM5/4/12
to Jon Salz, Zdenek Behan, Chris Sosa, Scott Zawalski, Mike Frysinger, Gerrit
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52: dev-lang/closure-compiler-bin
i missed this the first time around, but this ebuild needs to be revbumped when updating

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>

Hsinyu Chao (Code Review)

unread,
May 10, 2012, 3:49:16 AM5/10/12
to
Hsinyu Chao has uploaded a new change for review.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Build static directory (containing JS/CSS for factory UI).

This CL takes over the work of the reverted CL and fixed by
version bump hard-host-depends.
The original Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d

BUG=None
TEST=Build and run

Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
---
M chromeos-base/autotest/autotest-9999.ebuild
R chromeos-base/hard-host-depends/hard-host-depends-0.0.1-r122.ebuild
M chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
3 files changed, 2 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/45/22345/1
--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>

Tammo Spalink (Code Review)

unread,
May 10, 2012, 4:16:05 AM5/10/12
to Hsinyu Chao, Mike Frysinger, Jon Salz
Tammo Spalink has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Tammo Spalink <ta...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 10, 2012, 11:25:37 AM5/10/12
to Hsinyu Chao, Tammo Spalink, Mike Frysinger, Jon Salz
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 1: Fails

the lack of a bump to hard host depends isn't why it broke. please see http://crosbug.com/30547 ... once that's been addressed, we can add this.

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>

Hsinyu Chao (Code Review)

unread,
May 11, 2012, 2:12:01 AM5/11/12
to Tammo Spalink, Mike Frysinger, Jon Salz
Hsinyu Chao has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 2: Verified

Rebased.

The cause of failure in http://crosbug.com/30547 was lacking of java. Which will be included in dependencies of dev-lang/closure-compiler-bin, which added to hard-host-depends in this cl. Therefore I think version bump is the correct way to fix it. Please take a look at the trybot result of my rebased change: http://chromegw/p/tryserver.chromiumos/builders/alex-paladin/builds/143

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 11, 2012, 4:01:19 AM5/11/12
to Hsinyu Chao, Tammo Spalink, Mike Frysinger, Jon Salz
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 2: Looks good to me, approved

i guess we'll find out in the CQ ;)

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>

Hsinyu Chao (Code Review)

unread,
May 11, 2012, 4:30:39 AM5/11/12
to Tammo Spalink, Mike Frysinger, Jon Salz
Hsinyu Chao has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................


Patch Set 2: Ready

Thanks for the quick review!

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Reply all
Reply to author
Forward
0 new messages