faft: Directly run usbkm232-xxx commands on devices without ... [chromiumos/third_party/autotest : master]

18 views
Skip to first unread message

Tom Wai-Hong Tam (Code Review)

unread,
Oct 29, 2012, 6:11:43 AM10/29/12
to
Tom Wai-Hong Tam has uploaded a new change for review.

Change subject: faft: Directly run usbkm232-xxx commands on devices without build-in keyboards
......................................................................

faft: Directly run usbkm232-xxx commands on devices without build-in keyboards

For the device without build-in keyboards, we use an additional USBKM232
device, which is connected between servo board and DUT, to emulate an
external USB keyboard. The key-sending commands are ready, like usbkm232-enter,
usbkm232-ctrld, etc. So far we pass this commands to FAFT via arguments
manually. However, an user may forget to pass these arguments to the test
and cause a test error.

This CL is to run the commands directly without configuring them. A simple
check is added to ensure the environment variable USBKM232_UART_DEVICE is
set correctly.

BUG=chromium-os:34823
TEST=run on the devices without build-in keyboards:
run_remote_tests.sh --board stumpy --remote dut FAFTSetup

Change-Id: Ibd2bf71a4324cb1d209afea8561eae1a261be199
---
M server/cros/faftsequence.py
M server/site_tests/firmware_DevBootUSB/firmware_DevBootUSB.py
M server/site_tests/firmware_FAFTSetup/firmware_FAFTSetup.py
3 files changed, 18 insertions(+), 42 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/70/36770/1
--
To view, visit https://gerrit.chromium.org/gerrit/36770
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd2bf71a4324cb1d209afea8561eae1a261be199
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Tom Wai-Hong Tam <wai...@chromium.org>

Vic Yang (Code Review)

unread,
Oct 30, 2012, 2:14:12 AM10/30/12
to Tom Wai-Hong Tam, Gerrit, Mike Truty, Vadim Bendebury, Yusuf Mohsinally
Vic Yang has posted comments on this change.

Change subject: faft: Directly run usbkm232-xxx commands on devices without build-in keyboards
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/36770
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2bf71a4324cb1d209afea8561eae1a261be199
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Gerrit-Reviewer: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Yusuf Mohsinally <mohsi...@chromium.org>

Tom Wai-Hong Tam (Code Review)

unread,
Oct 30, 2012, 3:57:03 AM10/30/12
to Gerrit, Mike Truty, Vadim Bendebury, Vic Yang, Yusuf Mohsinally
Tom Wai-Hong Tam has posted comments on this change.

Change subject: faft: Directly run usbkm232-xxx commands on devices without build-in keyboards
......................................................................


Patch Set 3: Verified; Looks good to me, approved; Ready

Just rebased.

--
To view, visit https://gerrit.chromium.org/gerrit/36770
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2bf71a4324cb1d209afea8561eae1a261be199
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Tom Wai-Hong Tam <wai...@chromium.org>
Reply all
Reply to author
Forward
0 new messages