Received: by 10.58.218.102 with SMTP id pf6mr1497394vec.36.1352404574658;
        Thu, 08 Nov 2012 11:56:14 -0800 (PST)
X-BeenThere: chromium-os-revi...@chromium.org
Received: by 10.52.34.13 with SMTP id v13ls3880334vdi.3.gmail; Thu, 08 Nov
 2012 11:56:14 -0800 (PST)
Received: by 10.52.23.225 with SMTP id p1mr7198082vdf.79.1352404574098;
        Thu, 08 Nov 2012 11:56:14 -0800 (PST)
Received: by 10.52.23.225 with SMTP id p1mr7198080vdf.79.1352404574072;
        Thu, 08 Nov 2012 11:56:14 -0800 (PST)
Return-Path: <ger...@chromium.org>
Received: from ns1.golo.chromium.org (postal.chromium.org [74.125.248.75])
        by mx.google.com with ESMTP id qi2si22742779vec.24.2012.11.08.11.56.13;
        Thu, 08 Nov 2012 11:56:14 -0800 (PST)
Received-SPF: pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) client-ip=74.125.248.75;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) smtp.mail=ger...@chromium.org
Message-Id: <509c0e5e.02de3a0a.6fcf.ffffc882SMTPIN_ADDED@mx.google.com>
Received: from 192.168.20.14 (gerrit.golo.chromium.org [192.168.20.14])
	by ns1.golo.chromium.org (Postfix) with ESMTP id 26ACB162A3A;
	Thu,  8 Nov 2012 11:56:13 -0800 (PST)
Date: Thu, 8 Nov 2012 11:56:13 -0800
From: "Simon Que (Code Review)" <ger...@chromium.org>
CC: Gerrit <chrome-...@google.com>, Sameer Nanda <sna...@chromium.org>,
	Daniel Erat <de...@chromium.org>, Todd Broch <tbr...@chromium.org>,
	=?UTF-8?Q?St=C3=A9phane_Marchesin?= <marc...@chromium.org>
Reply-To: s...@chromium.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?client/site=5Ftests:_add_power=5FBacklightControl_test_[chromiumos/third=5Fparty/autotest_:_master]=0A?=
X-Gerrit-Change-Id: Id399956ee55443d711429c191839bb227885da16
Mailing-List: list gerrit-chromiumos-third_party-autot...@gerrit.chromium.org
List-Id: <gerrit-chromiumos-third_party-autotest.gerrit.chromium.org>
List-Unsubscribe: <https://gerrit.chromium.org/gerrit/settings>
X-Gerrit-ChangeURL: <https://gerrit.chromium.org/gerrit/37388>
X-Gerrit-Commit: 596c83e707b149a257fb103ced91c657df5245c8
In-Reply-To: <gerrit.1352158160246.Id399956ee55443d711429c191839bb227885d...@gerrit.chromium.org>
References: <gerrit.1352158160246.Id399956ee55443d711429c191839bb227885d...@gerrit.chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.4.2

Simon Que has posted comments on this change.

Change subject: client/site_tests: add power_BacklightControl test
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File client/site_tests/power_BacklightControl/power_BacklightControl.py
Line 204:         command = ('dbus-send --type=method_call --system ' + \
If I'm understanding you correctly, this is only useful for:
  1. in the start -> max transition, the last step
  2. in the max -> min transition, the later steps that go below max / 2.

Correct me if I'm wrong.

--
To view, visit https://gerrit.chromium.org/gerrit/37388
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id399956ee55443d711429c191839bb227885da16
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Simon Que <s...@chromium.org>
Gerrit-Reviewer: Daniel Erat <de...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Sameer Nanda <sna...@chromium.org>
Gerrit-Reviewer: Simon Que <s...@chromium.org>
Gerrit-Reviewer: Stéphane Marchesin <marc...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>