Use -maxvt flag to disable VT switching. [chromiumos/platform/login_manager : master]

26 views
Skip to first unread message

Yoshiki IGUCHI (Code Review)

unread,
Oct 23, 2012, 12:10:23 AM10/23/12
to Yoshiki IGUCHI
Yoshiki IGUCHI has uploaded a new change for review.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................

Use -maxvt flag to disable VT switching.

BUG=chromium:153961, chromium-os:35606
TEST=manual

Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
---
M xstart.sh
1 file changed, 10 insertions(+), 1 deletion(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/login_manager refs/changes/15/36315/1
--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>

Yoshiki IGUCHI (Code Review)

unread,
Oct 23, 2012, 12:11:04 AM10/23/12
to Yoshiki IGUCHI, Daniel Erat
Yoshiki IGUCHI has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 1: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Daniel Erat <de...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>

Daniel Erat (Code Review)

unread,
Oct 23, 2012, 12:26:45 AM10/23/12
to Yoshiki IGUCHI
Daniel Erat has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File xstart.sh
Line 10: # if we're in verified boot moder. Otherwise, disables only Fn (n>=3) keys.
nit: s/moder/mode/

Line 12: if [ -e /var/run/state/allow-vt-switching ]; then
i don't think that this will work; you'd probably be better off duplicating the

crossystem "cros_debug?1" || grep -q '^chronos:[^*]' /etc/shadow

check from hotkey-access.conf. the hotkey-access job starts on "login-prompt-visible or starting failsafe", so X will already be started by the time that the allow-vt-switching file gets created. that's why the previous X patch checked for the file dynamically whenever a VC-switching key was pressed instead of just checking it at startup.

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>

Yoshiki IGUCHI (Code Review)

unread,
Oct 23, 2012, 1:13:26 AM10/23/12
to Yoshiki IGUCHI, Daniel Erat
Yoshiki IGUCHI has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File xstart.sh
Line 10: # if we're in verified boot moder. Otherwise, disables only Fn (n>=3) keys.
Done

Line 12: if [ -e /var/run/state/allow-vt-switching ]; then
Done. Thanks!

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>

Daniel Erat (Code Review)

unread,
Oct 23, 2012, 9:35:47 AM10/23/12
to Yoshiki IGUCHI
Daniel Erat has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>

Yoshiki IGUCHI (Code Review)

unread,
Oct 23, 2012, 11:15:41 AM10/23/12
to Yoshiki IGUCHI, Daniel Erat
Yoshiki IGUCHI has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 2: Verified; Ready

Thanks for review!

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>

David James (Code Review)

unread,
Oct 23, 2012, 1:50:59 PM10/23/12
to Yoshiki IGUCHI, Daniel Erat
David James has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 2: Fails

Could you try running this CL with VMTest? I tried running this CL with remote trybot and it seems to fail VMTest every time. Example: http://chromegw.corp.google.com/i/chromiumos.tryserver/builders/mario-paladin/builds/856

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Daniel Erat <de...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>

Yoshiki IGUCHI (Code Review)

unread,
Oct 29, 2012, 1:24:27 AM10/29/12
to Yoshiki IGUCHI, Daniel Erat, David James
Yoshiki IGUCHI has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 2:

I tried this just now and it seems to succeed without error.
http://chromegw.corp.google.com/i/chromiumos.tryserver/builders/mario-paladin/builds/894
http://chromegw.corp.google.com/i/chromiumos.tryserver/builders/lumpy-paladin/builds/351

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>

David James (Code Review)

unread,
Oct 29, 2012, 12:05:14 PM10/29/12
to Yoshiki IGUCHI, Daniel Erat
David James has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 2: No score

Thanks for double checking!

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>

Yoshiki IGUCHI (Code Review)

unread,
Oct 29, 2012, 8:19:20 PM10/29/12
to Yoshiki IGUCHI, Daniel Erat
Yoshiki IGUCHI has posted comments on this change.

Change subject: Use -maxvt flag to disable VT switching.
......................................................................


Patch Set 2: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/36315
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Yoshiki IGUCHI <yos...@chromium.org>
Gerrit-Reviewer: Daniel Erat <de...@chromium.org>
Gerrit-Reviewer: Yoshiki IGUCHI <yos...@chromium.org>
Reply all
Reply to author
Forward
0 new messages