Add missing patch to mesa-9999.ebuild [chromiumos/overlays/chromiumos-overlay : release-R23-2913.B]

Stuart Abercrombie (Code Review)

unread,

Nov 5, 2012, 7:40:16 PM11/5/12

to

Stuart Abercrombie has uploaded a new change for review.

Change subject: Add missing patch to mesa-9999.ebuild
......................................................................

Add missing patch to mesa-9999.ebuild

I forgot to add the guardband disable patch.

Without this change cros_workoned mesa won't have correct viewport clipping.

BUG=chromium-os:33526
TEST=Lumpy cros_workoned Mesa now clips correctly

Change-Id: I44a9b2b734491924aeade98d17efa01ddf1c3759
---
M media-libs/mesa/mesa-9999.ebuild
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/97/37397/1
--
To view, visit https://gerrit.chromium.org/gerrit/37397
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44a9b2b734491924aeade98d17efa01ddf1c3759
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Stuart Abercrombie <saberc...@chromium.org>

Stuart Abercrombie (Code Review)

unread,

Nov 5, 2012, 7:41:50 PM11/5/12

to Gerrit, Stéphane Marchesin, Frank Henigman

Stuart Abercrombie has posted comments on this change.

Change subject: Add missing patch to mesa-9999.ebuild
......................................................................

Patch Set 1: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/37397
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I44a9b2b734491924aeade98d17efa01ddf1c3759
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Stuart Abercrombie <saberc...@chromium.org>

Gerrit-Reviewer: Frank Henigman <fjhen...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Stuart Abercrombie <saberc...@chromium.org>
Gerrit-Reviewer: Stéphane Marchesin <mar...@chromium.org>

Frank Henigman (Code Review)

unread,

Nov 5, 2012, 7:46:56 PM11/5/12

to Stuart Abercrombie, Gerrit, Stéphane Marchesin

Frank Henigman has posted comments on this change.

Change subject: Add missing patch to mesa-9999.ebuild
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/37397
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I44a9b2b734491924aeade98d17efa01ddf1c3759
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Stuart Abercrombie <saberc...@chromium.org>

Stéphane Marchesin (Code Review)

unread,

Nov 6, 2012, 1:35:02 AM11/6/12

to Stuart Abercrombie, Gerrit, Frank Henigman

Stéphane Marchesin has posted comments on this change.

Change subject: Add missing patch to mesa-9999.ebuild
......................................................................

Patch Set 1: Looks good to me, approved

Does that matter on the R23 branch though?

--
To view, visit https://gerrit.chromium.org/gerrit/37397
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I44a9b2b734491924aeade98d17efa01ddf1c3759
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Stuart Abercrombie <saberc...@chromium.org>

Stuart Abercrombie (Code Review)

unread,

Nov 6, 2012, 4:57:46 PM11/6/12

to Gerrit, Stéphane Marchesin, Frank Henigman

Stuart Abercrombie has submitted this change and it was merged.

Change subject: Add missing patch to mesa-9999.ebuild
......................................................................

Add missing patch to mesa-9999.ebuild

I forgot to add the guardband disable patch.

Without this change cros_workoned mesa won't have correct viewport clipping.

BUG=chromium-os:33526
TEST=Lumpy cros_workoned Mesa now clips correctly

Change-Id: I44a9b2b734491924aeade98d17efa01ddf1c3759
---
M media-libs/mesa/mesa-9999.ebuild
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
Stéphane Marchesin: Looks good to me, approved
Stuart Abercrombie: Verified
Frank Henigman: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/37397
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged

Gerrit-Change-Id: I44a9b2b734491924aeade98d17efa01ddf1c3759
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Stuart Abercrombie <saberc...@chromium.org>

Reply all

Reply to author

Forward