faft: Use better names for key-pressing methods and remove S... [chromiumos/third_party/autotest : master]

15 views
Skip to first unread message

Tom Wai-Hong Tam (Code Review)

unread,
Oct 29, 2012, 4:59:16 AM10/29/12
to
Tom Wai-Hong Tam has uploaded a new change for review.

Change subject: faft: Use better names for key-pressing methods and remove Space support
......................................................................

faft: Use better names for key-pressing methods and remove Space support

This CL renames send_xxx_to_dut() to press_xxx(), more readable. And remove
the Space key support since we now use Enter as an alternative key by
setting the GBB flag ENTER_TRIGGERS_TONORM.

BUG=chromium-os:35792
TEST=run_remote_tests.sh --board link --remote dut suite:faft

Change-Id: Ibdb5a0c88fe7752600773f6d32052750eedd6e9b
---
M server/cros/faftsequence.py
M server/site_tests/firmware_DevBootUSB/firmware_DevBootUSB.py
M server/site_tests/firmware_DevScreenTimeout/firmware_DevScreenTimeout.py
M server/site_tests/firmware_FAFTSetup/firmware_FAFTSetup.py
4 files changed, 15 insertions(+), 26 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/67/36767/1
--
To view, visit https://gerrit.chromium.org/gerrit/36767
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdb5a0c88fe7752600773f6d32052750eedd6e9b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Tom Wai-Hong Tam <wai...@chromium.org>

Vic Yang (Code Review)

unread,
Oct 30, 2012, 2:08:09 AM10/30/12
to Tom Wai-Hong Tam, Gerrit, Mike Truty, Vadim Bendebury, Yusuf Mohsinally
Vic Yang has posted comments on this change.

Change subject: faft: Use better names for key-pressing methods and remove Space support
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/36767
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdb5a0c88fe7752600773f6d32052750eedd6e9b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Gerrit-Reviewer: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Yusuf Mohsinally <mohsi...@chromium.org>

Tom Wai-Hong Tam (Code Review)

unread,
Oct 30, 2012, 2:23:48 AM10/30/12
to Gerrit, Mike Truty, Vadim Bendebury, Vic Yang, Yusuf Mohsinally
Tom Wai-Hong Tam has posted comments on this change.

Change subject: faft: Use better names for key-pressing methods and remove Space support
......................................................................


Patch Set 1: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/36767
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdb5a0c88fe7752600773f6d32052750eedd6e9b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>

Tom Wai-Hong Tam (Code Review)

unread,
Oct 30, 2012, 3:56:32 AM10/30/12
to Vic Yang, Gerrit
Tom Wai-Hong Tam has posted comments on this change.

Change subject: faft: Use better names for key-pressing methods and remove Space support
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

Just rebased.

--
To view, visit https://gerrit.chromium.org/gerrit/36767
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdb5a0c88fe7752600773f6d32052750eedd6e9b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vic Yang <victo...@chromium.org>
Reply all
Reply to author
Forward
0 new messages