Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
Message from discussion samsung: snow: bitfix: Recover from bit errors across sleep/... [chromiumos/third_party/kernel : chromeos-3.4]
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Will Drewry (Code Review)  
View profile  
 More options Nov 2 2012, 2:22 pm
From: "Will Drewry (Code Review)" <ger...@chromium.org>
Date: Fri, 2 Nov 2012 11:22:43 -0700
Local: Fri, Nov 2 2012 2:22 pm
Subject: samsung: snow: bitfix: Recover from bit errors across sleep/... [chromiumos/third_party/kernel : chromeos-3.4]
Print | View thread | Show original | Find messages by this author
Will Drewry has posted comments on this change.

Change subject: samsung: snow: bitfix: Recover from bit errors across sleep/wake
......................................................................

Patch Set 14: (2 inline comments)

uh, comment review :)  (Code looks tidy, but I didn't spend the time needed to be a solid reviewer.)

....................................................
File arch/arm/mach-exynos/bitfix-snow.c
Line 75:  * We'll then rely on an out-of-band singnal (CRC) to identify bad chunks (8K)
typo: signal

Line 77:  * will recompute it.  Since all bad chunks are in a single corrutpion unit
typo: corruption

--
To view, visit https://gerrit.chromium.org/gerrit/36905
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7ac2f85b8d9398c93f486f9401daee1526f571
Gerrit-PatchSet: 14
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Doug Anderson <diand...@chromium.org>
Gerrit-Reviewer: Doug Anderson <diand...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Jon Kliegman <kli...@chromium.org>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-Reviewer: Olof Johansson <ol...@chromium.org>
Gerrit-Reviewer: Will Drewry <w...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google