Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Message from discussion CHROMIUM: config: enable usb net drivers (dm9601/net1080/rtl... [chromiumos/third_party/kernel : chromeos-3.4]
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Doug Anderson (Code Review)  
View profile  
 More options Nov 11 2012, 5:51 pm
From: "Doug Anderson (Code Review)" <ger...@chromium.org>
Date: Sun, 11 Nov 2012 14:51:30 -0800
Local: Sun, Nov 11 2012 5:51 pm
Subject: CHROMIUM: config: enable usb net drivers (dm9601/net1080/rtl... [chromiumos/third_party/kernel : chromeos-3.4]
Doug Anderson has posted comments on this change.

Change subject: CHROMIUM: config: enable usb net drivers (dm9601/net1080/rtl8150) for all targets
......................................................................

Patch Set 3: I would prefer that you didn't submit this

Yup, this is just what I was looking for.  Thanks!

* For NET1080 and DM9601: no problem.  If we include these modules for x86 then I agree that we should include them for ARM and have no problem giving the +2.
* For RTL8150: this one is a little different because it was only in the Chromium OS config.  I believe that we are less picky about what we put in there since that doesn't get used with shipping products.  By moving it you're adding a new driver for shipping x86 (and ARM) products.  See the CL where it was purposely added only to the Chromium OS config <https://gerrit.chromium.org/gerrit/#/c/2599/>.  

Are there common USB ethernet adapters that use the RTL8150 driver?  Do we think the driver quality is good enough that we want users to be using it?

Marking -1 until sufficient justification for RTL8150.  ...if Olof (or someone else) wants to +2 I have no problem with that, though.

--
To view, visit https://gerrit.chromium.org/gerrit/37296
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9615109a5b17af293855595ba8f06f397db360c4
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Doug Anderson <diand...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Jon Kliegman <kli...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Olof Johansson <ol...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.