Received: by 10.58.151.78 with SMTP id uo14mr1201494veb.17.1352247352795;
        Tue, 06 Nov 2012 16:15:52 -0800 (PST)
X-BeenThere: chromium-os-revi...@chromium.org
Received: by 10.220.219.69 with SMTP id ht5ls1287304vcb.7.gmail; Tue, 06 Nov
 2012 16:15:52 -0800 (PST)
Received: by 10.220.210.193 with SMTP id gl1mr2514239vcb.58.1352247352161;
        Tue, 06 Nov 2012 16:15:52 -0800 (PST)
Received: by 10.220.210.193 with SMTP id gl1mr2514237vcb.58.1352247352142;
        Tue, 06 Nov 2012 16:15:52 -0800 (PST)
Return-Path: <ger...@chromium.org>
Received: from ns1.golo.chromium.org (postal.chromium.org [74.125.248.75])
        by mx.google.com with ESMTP id x12si14239848vco.28.2012.11.06.16.15.52;
        Tue, 06 Nov 2012 16:15:52 -0800 (PST)
Received-SPF: pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) client-ip=74.125.248.75;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) smtp.mail=ger...@chromium.org
Message-Id: <5099a838.8c6adc0a.28c5.53abSMTPIN_ADDED@mx.google.com>
Received: from 192.168.20.14 (gerrit.golo.chromium.org [192.168.20.14])
	by ns1.golo.chromium.org (Postfix) with ESMTP id EB273160E33;
	Tue,  6 Nov 2012 16:15:51 -0800 (PST)
Date: Tue, 6 Nov 2012 16:15:51 -0800
From: "Simon Que (Code Review)" <ger...@chromium.org>
CC: Gerrit <chrome-...@google.com>, Sameer Nanda <sna...@chromium.org>,
	Daniel Erat <de...@chromium.org>, Todd Broch <tbr...@chromium.org>,
	=?UTF-8?Q?St=C3=A9phane_Marchesin?= <marc...@chromium.org>
Reply-To: s...@chromium.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?client/site=5Ftests:_add_power=5FBacklightControl_test_[chromiumos/third=5Fparty/autotest_:_master]=0A?=
X-Gerrit-Change-Id: Id399956ee55443d711429c191839bb227885da16
Mailing-List: list gerrit-chromiumos-third_party-autot...@gerrit.chromium.org
List-Id: <gerrit-chromiumos-third_party-autotest.gerrit.chromium.org>
List-Unsubscribe: <https://gerrit.chromium.org/gerrit/settings>
X-Gerrit-ChangeURL: <https://gerrit.chromium.org/gerrit/37388>
X-Gerrit-Commit: d7b2fe7e3bd48db9b35a876890a28bb62736d6d0
In-Reply-To: <gerrit.1352158160246.Id399956ee55443d711429c191839bb227885d...@gerrit.chromium.org>
References: <gerrit.1352158160246.Id399956ee55443d711429c191839bb227885d...@gerrit.chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.4.2

Simon Que has posted comments on this change.

Change subject: client/site_tests: add power_BacklightControl test
......................................................................


Patch Set 3: (12 inline comments)

....................................................
File client/site_tests/power_BacklightControl/control
Line 15:   - There are too many steps (> 16) between min and max brightness.
Done.

I think that should be done in power_Backlight.

....................................................
File client/site_tests/power_BacklightControl/power_BacklightControl.py
Line 79: 
Done

Line 83:         os.system('rm %s/*' % self._pref_path)
Done

Line 106: 
Maybe these should be keyvals?

Line 112:         # Set brightness to max.
I'm setting brightness from: (initial brightness) -> max -> min -> 0 -> max, that should cover the whole range.

Line 117:             time.sleep(adjustment_delay_s)
The dbus message indicating changing brightness is sent out at the beginning, not at the end.

I we could just poll backlight-tool.

Line 140:         # Turn off the screen by decreasing brightness one more time.
Done

Line 196:         pass
Done

Line 201:         pass
Done

Line 205:         cmd = 'backlight-tool --get_max_brightness'
This is meant to test the backlight controller, not the backlight interface.  Any failures in backlight-tool should be caught by power_Backlight.

Line 207:         if max_brightness < 4:
Done

Line 220:         XSET = 'LD_LIBRARY_PATH=/usr/local/lib xset'
Done

--
To view, visit https://gerrit.chromium.org/gerrit/37388
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id399956ee55443d711429c191839bb227885da16
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Simon Que <s...@chromium.org>
Gerrit-Reviewer: Daniel Erat <de...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Sameer Nanda <sna...@chromium.org>
Gerrit-Reviewer: Simon Que <s...@chromium.org>
Gerrit-Reviewer: Stéphane Marchesin <marc...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>