Add flashrom EC support [chromiumos/platform/saft : master]

19 views
Skip to first unread message

Vic Yang (Code Review)

unread,
May 18, 2012, 5:28:09 AM5/18/12
to
Vic Yang has uploaded a new change for review.

Change subject: Add flashrom EC support
......................................................................

Add flashrom EC support

Current flashrom module only support reading/writing BIOS. To enable EC
FAFT, let's add flashrom EC support.

BUG=chrome-os-partner:9188
TEST=Manual test.

Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
---
M flashrom_handler.py
M saft_flashrom_util.py
2 files changed, 28 insertions(+), 14 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/saft refs/changes/31/23031/1
--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>

Tom Wai-Hong Tam (Code Review)

unread,
May 18, 2012, 8:36:48 PM5/18/12
to Vic Yang
Tom Wai-Hong Tam has posted comments on this change.

Change subject: Add flashrom EC support
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

LGTM w/ nit.

....................................................
Commit Message
Line 13: TEST=Manual test.
Please add more detailed steps about your test. At least, it doesn't break the existing bios FAFT tests.

--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>

Tom Wai-Hong Tam (Code Review)

unread,
May 21, 2012, 2:50:24 AM5/21/12
to Vic Yang
Tom Wai-Hong Tam has posted comments on this change.

Change subject: Add flashrom EC support
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vic Yang <victo...@chromium.org>

Vic Yang (Code Review)

unread,
May 21, 2012, 2:51:21 AM5/21/12
to Tom Wai-Hong Tam
Vic Yang has posted comments on this change.

Change subject: Add flashrom EC support
......................................................................


Patch Set 2: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Reply all
Reply to author
Forward
0 new messages