Received: by 10.224.180.141 with SMTP id bu13mr4184884qab.2.1353117829004;
        Fri, 16 Nov 2012 18:03:49 -0800 (PST)
X-BeenThere: chromium-os-revi...@chromium.org
Received: by 10.49.39.170 with SMTP id q10ls1270831qek.13.gmail; Fri, 16 Nov
 2012 18:03:48 -0800 (PST)
Received: by 10.229.176.29 with SMTP id bc29mr1412946qcb.113.1353117828429;
        Fri, 16 Nov 2012 18:03:48 -0800 (PST)
Received: by 10.229.176.29 with SMTP id bc29mr1412944qcb.113.1353117828377;
        Fri, 16 Nov 2012 18:03:48 -0800 (PST)
Return-Path: <ger...@chromium.org>
Received: from ns1.golo.chromium.org (postal.chromium.org [74.125.248.75])
        by mx.google.com with ESMTP id s12si1050296qct.55.2012.11.16.18.03.47;
        Fri, 16 Nov 2012 18:03:48 -0800 (PST)
Received-SPF: pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) client-ip=74.125.248.75;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) smtp.mail=ger...@chromium.org
Message-Id: <50a6f084.cc88e50a.1fb9.1aefSMTPIN_ADDED@mx.google.com>
Received: from 192.168.20.14 (gerrit.golo.chromium.org [192.168.20.14])
	by ns1.golo.chromium.org (Postfix) with ESMTP id 5470E162A81;
	Fri, 16 Nov 2012 18:03:47 -0800 (PST)
Date: Fri, 16 Nov 2012 18:03:47 -0800
From: "David James (Code Review)" <ger...@chromium.org>
To: Ryan Cui <r...@chromium.org>
CC: Chris Sosa <s...@chromium.org>,
	Mike Frysinger <vap...@chromium.org>,
	Peter Mayo <peterm...@chromium.org>,
	Gerrit <chrome-...@google.com>
Reply-To: davidja...@chromium.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?Enable_deploy=5Fchrome.py_to_deploy_from_a_build_output_direct...__[chromiumos/chromite_:_master]=0A?=
X-Gerrit-Change-Id: I25bc3f5afc0fd80fd5e664c75cbd3524b9716831
Mailing-List: list gerrit-chromiumos-chrom...@gerrit.chromium.org
List-Id: <gerrit-chromiumos-chromite.gerrit.chromium.org>
List-Unsubscribe: <https://gerrit.chromium.org/gerrit/settings>
X-Gerrit-ChangeURL: <https://gerrit.chromium.org/gerrit/36020>
X-Gerrit-Commit: d61d6be53af333965e81a62a18662c15e90e6717
In-Reply-To: <gerrit.1350610877926.I25bc3f5afc0fd80fd5e664c75cbd3524b9716...@gerrit.chromium.org>
References: <gerrit.1350610877926.I25bc3f5afc0fd80fd5e664c75cbd3524b9716...@gerrit.chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.4.2

David James has posted comments on this change.

Change subject: Enable deploy_chrome.py to deploy from a build output directory.
......................................................................


Patch Set 13: Looks good to me, approved

(3 inline comments)

....................................................
File lib/chrome_util.py
Line 140:       shutil.copy(src, dest)
Why can't we use shutil.copytree regardless, even if it's not a dir? That'd cut out 2 lines of code.

....................................................
File lib/cros_test_lib.py
Line 31:     if isinstance(obj, tuple):
I'd think the check would be for basestring, not tuple, since that way your function would work with lists as well.

i.e.

if isinstance(obj, basestring):
  flattened.append(os.path.join(base_path, obj))
else:
  ...

Line 52:         - ['file1', ('directory', ['deepfile1', 'deepfile2']), 'file2']
Looks like you're switching between tuples and lists here... why?

--
To view, visit https://gerrit.chromium.org/gerrit/36020
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25bc3f5afc0fd80fd5e664c75cbd3524b9716831
Gerrit-PatchSet: 13
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Ryan Cui <r...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Peter Mayo <peterm...@chromium.org>
Gerrit-Reviewer: Ryan Cui <r...@chromium.org>