Change subject: Enable deploy_chrome.py to deploy from a build output directory.
......................................................................

Patch Set 6: (1 inline comment)

....................................................
File lib/chrome_util.py
Line 190:       if _CheckForGlobPatterns(path.src):
As per our conversation, I'd still prefer checking to see if the src path is a glob pattern.  It's not hard to implement, and avoids an error case where the trailing slash is not specified.

Ultimately, checking for glob pattern vs. looking at trailing slash of dest is to cover the case where a glob pattern is specified but matches only one file/directory, in which case we don't know whether to treat the custom 'dest' as the containing directory or the final target path.

It's funny that we are going back and forth on this, because there's actually no usage of the functionality (globbing to a containing dir) yet...

Please take a look at my latest patchset, where the refactored logic looks more like what you have here (minus the check for trailing slash).

--
To view, visit https://gerrit.chromium.org/gerrit/36020
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25bc3f5afc0fd80fd5e664c75cbd3524b9716831
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Ryan Cui <r...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Peter Mayo <peterm...@chromium.org>
Gerrit-Reviewer: Ryan Cui <r...@chromium.org>