Add CRASFormatConversion autotest. [chromiumos/third_party/autotest : master]

16 views
Skip to first unread message

Dylan Reid (Code Review)

unread,
Jun 26, 2012, 11:22:45 PM6/26/12
to
Dylan Reid has uploaded a new change for review.

Change subject: Add CRASFormatConversion autotest.
......................................................................

Add CRASFormatConversion autotest.

This test plays two streams simultaneously at different sample rates to
test the sample rate converter in CRAS output. All combinations of
common sample rates are tested, this takes a few minutes. Then every
sample rate is used to capture audio, testing format converts for input.

BUG=none.
TEST=run_remote_test --use_emerge audiovideo_CRASFormatConversion

Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Signed-off-by: Dylan Reid <dgr...@chromium.org>
---
A client/site_tests/audiovideo_CRASFormatConversion/audiovideo_CRASFormatConversion.py
A client/site_tests/audiovideo_CRASFormatConversion/control
A client/site_tests/audiovideo_CRASFormatConversion/sine.wav
3 files changed, 164 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/99/26199/1
--
To view, visit https://gerrit.chromium.org/gerrit/26199
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Hsinyu Chao (Code Review)

unread,
Nov 8, 2012, 9:02:40 PM11/8/12
to Dylan Reid, Gerrit
Hsinyu Chao has posted comments on this change.

Change subject: Add CRASFormatConversion autotest.
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

I tried run this test on Lumpy and keep seeing 'Got audio RMS value of 0.140245' fail at the first frequency pair. Curious does this test pass all the time for you?

....................................................
File client/site_tests/audiovideo_CRASFormatConversion/audiovideo_CRASFormatConversion.py
Line 42: cmd_rec = ('cras_test_client '
How about use _TEST_CLIENT instead of cras_test_client?

--
To view, visit https://gerrit.chromium.org/gerrit/26199
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>

Dylan Reid (corp, do not use) (Code Review)

unread,
Nov 9, 2012, 2:00:14 AM11/9/12
to Dylan Reid, Gerrit, Hsinyu Chao
Dylan Reid (corp, do not use) has posted comments on this change.

Change subject: Add CRASFormatConversion autotest.
......................................................................


Patch Set 3:

I was seeing it pass consistently on lumpy, I'll give it another try tomorrow,
Thanks,

Dylan

--
To view, visit https://gerrit.chromium.org/gerrit/26199
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid (corp, do not use) <dgr...@google.com>

Dylan Reid (Code Review)

unread,
Nov 9, 2012, 9:37:00 PM11/9/12
to Gerrit, Hsinyu Chao
Dylan Reid has posted comments on this change.

Change subject: Add CRASFormatConversion autotest.
......................................................................


Patch Set 4:

Changes in PS4:

New sine.wav, that is half the amplitude to reduce clipping when mixing, reduce threshold as well, since this could be very low depending on phase alignment of the mixed sine waves.

use test client define.

--
To view, visit https://gerrit.chromium.org/gerrit/26199
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Hsinyu Chao (Code Review)

unread,
Nov 10, 2012, 8:32:55 AM11/10/12
to Dylan Reid, Gerrit
Hsinyu Chao has posted comments on this change.

Change subject: Add CRASFormatConversion autotest.
......................................................................


Patch Set 4: Looks good to me, approved

Cool, it works good for all rate pairs now.

--
To view, visit https://gerrit.chromium.org/gerrit/26199
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Nov 14, 2012, 4:34:03 PM11/14/12
to Gerrit, Hsinyu Chao
Dylan Reid has posted comments on this change.

Change subject: Add CRASFormatConversion autotest.
......................................................................


Patch Set 4: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/26199
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Reply all
Reply to author
Forward
0 new messages