Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
Message from discussion Add CRASFormatConversion autotest. [chromiumos/third_party/autote st : master]
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Hsinyu Chao (Code Review)  
View profile  
 More options Nov 8 2012, 9:02 pm
From: "Hsinyu Chao (Code Review)" <ger...@chromium.org>
Date: Thu, 8 Nov 2012 18:02:40 -0800
Local: Thurs, Nov 8 2012 9:02 pm
Subject: Add CRASFormatConversion autotest. [chromiumos/third_party/autotest : master]
Print | View thread | Show original | Find messages by this author
Hsinyu Chao has posted comments on this change.

Change subject: Add CRASFormatConversion autotest.
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

I tried run this test on Lumpy and keep seeing 'Got audio RMS value of 0.140245' fail at the first frequency pair. Curious does this test pass all the time for you?

....................................................
File client/site_tests/audiovideo_CRASFormatConversion/audiovideo_CRASFormatConv ersion.py
Line 42:         cmd_rec = ('cras_test_client '
How about use  _TEST_CLIENT instead of cras_test_client?

--
To view, visit https://gerrit.chromium.org/gerrit/26199
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f189b9939070f2beac2c355437f2a351d273001
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google