Roll clang 155835:157931 [chromiumos/overlays/chromiumos-overlay : master]

39 views
Skip to first unread message

Denis Glotov (Code Review)

unread,
Jun 18, 2012, 6:18:06 AM6/18/12
to
Denis Glotov has uploaded a new change for review.

Change subject: Roll clang 155835:157931
......................................................................

Roll clang 155835:157931

FYI: chrome roll: http://codereview.chromium.org/10557027/

BUG=none
TEST=sudo emerge clang; cbuildbot [x86,amd64]-generic-asan --remote --buildbot --pass-through=--debug

Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
---
R sys-devel/clang/clang-3.1_pre157931.ebuild
M sys-devel/clang/clang-9999.ebuild
D sys-devel/llvm/files/llvm-2.6-commandguide-nops.patch
R sys-devel/llvm/llvm-3.1_pre157931.ebuild
M sys-devel/llvm/llvm-9999.ebuild
5 files changed, 6 insertions(+), 38 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/19/25519/1
--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Denis Glotov (Code Review)

unread,
Jun 18, 2012, 7:19:53 AM6/18/12
to Mike Frysinger
Denis Glotov has posted comments on this change.

Change subject: Roll clang 155835:157931
......................................................................


Patch Set 1: Verified

Hi!

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>
Gerrit-Reviewer: Denis Glotov <glo...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

Mike Frysinger (Code Review)

unread,
Jun 18, 2012, 12:53:35 PM6/18/12
to Denis Glotov, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:157931
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Mike Frysinger (Code Review)

unread,
Jul 10, 2012, 1:48:41 AM7/10/12
to Denis Glotov, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:159409
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Denis Glotov (Code Review)

unread,
Aug 3, 2012, 8:33:28 AM8/3/12
to Mike Frysinger
Denis Glotov has posted comments on this change.

Change subject: Roll clang 155835:160967
......................................................................


Patch Set 3:

Although llvm and clang build itself fine, the resulting Chrome have issues on x86: http://chromegw.corp.google.com/i/chromiumos.tryserver/builders/x86-generic-asan/builds/67/steps/VMTest/logs/stdio
Investigating...

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Mike Frysinger (Code Review)

unread,
Aug 4, 2012, 1:24:38 AM8/4/12
to Denis Glotov, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:160967
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Mike Frysinger (Code Review)

unread,
Oct 3, 2012, 11:37:55 AM10/3/12
to Denis Glotov, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:165097
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File sys-devel/clang/clang-3.2_pre165097.ebuild
Line 123: emake VERBOSE=1 KEEP_SYMBOLS=1 REQUIRES_RTTI=1 || die "emake failed"
this ebuild is EAPI=4, so you don't need the die with emake

....................................................
File sys-devel/clang/clang-9999.ebuild
Line 121: emake VERBOSE=1 KEEP_SYMBOLS=1 REQUIRES_RTTI=1 clang-only || die "emake failed"
in the other ebuild, you deleted the "clang-only", but you left it here

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Denis Glotov (Code Review)

unread,
Oct 3, 2012, 12:04:07 PM10/3/12
to Mike Frysinger
Denis Glotov has posted comments on this change.

Change subject: Roll clang 155835:165097
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File sys-devel/clang/clang-3.2_pre165097.ebuild
Line 123: emake VERBOSE=1 KEEP_SYMBOLS=1 REQUIRES_RTTI=1 || die "emake failed"
Done

....................................................
File sys-devel/clang/clang-9999.ebuild
Line 121: emake VERBOSE=1 KEEP_SYMBOLS=1 REQUIRES_RTTI=1 clang-only || die "emake failed"
Good catch. Fixed.

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Mike Frysinger (Code Review)

unread,
Oct 3, 2012, 12:33:38 PM10/3/12
to Denis Glotov, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:165097
......................................................................


Patch Set 5: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Mike Frysinger (Code Review)

unread,
Oct 29, 2012, 2:12:38 PM10/29/12
to Denis Glotov, Gerrit, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:165797
......................................................................


Patch Set 8:

re-add me when you finally plan on merging this

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 8
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>
Gerrit-Reviewer: Denis Glotov <glo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

Denis Glotov (Code Review)

unread,
Oct 30, 2012, 11:22:51 AM10/30/12
to Gerrit, Stuart Abercrombie, Mike Frysinger
Denis Glotov has posted comments on this change.

Change subject: Roll clang 155835:165797
......................................................................


Patch Set 10: Verified

Trybots pass:
http://chromegw/p/tryserver.chromiumos/builders/amd64-generic-asan/builds/77
http://chromegw/p/tryserver.chromiumos/builders/x86-generic-asan/builds/98

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 10
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>
Gerrit-Reviewer: Denis Glotov <glo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Stuart Abercrombie <saberc...@chromium.org>

Mike Frysinger (Code Review)

unread,
Oct 30, 2012, 4:30:23 PM10/30/12
to Denis Glotov, Gerrit, Stuart Abercrombie, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:165797
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File profiles/targets/chromeos/package.mask
Line 45: >sys-devel/llvm-3.1-r2
change to:

=sys-devel/llvm-3.2_pre*

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 10
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Mike Frysinger (Code Review)

unread,
Oct 31, 2012, 2:28:17 AM10/31/12
to Denis Glotov, Gerrit, Stuart Abercrombie, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Roll clang 155835:165797
......................................................................


Patch Set 11: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 11
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Denis Glotov (Code Review)

unread,
Oct 31, 2012, 2:47:34 AM10/31/12
to Gerrit, Stuart Abercrombie, Mike Frysinger
Denis Glotov has posted comments on this change.

Change subject: Roll clang 155835:165797
......................................................................


Patch Set 11: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 11
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>

Denis Glotov (Code Review)

unread,
Nov 1, 2012, 5:17:14 AM11/1/12
to Gerrit, Stuart Abercrombie, Mike Frysinger
Denis Glotov has posted comments on this change.

Change subject: Roll clang 155835:165797
......................................................................


Patch Set 11: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/25519
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71aff278b68d2d0e9c09941660d2b72621afbb0c
Gerrit-PatchSet: 11
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Denis Glotov <glo...@chromium.org>
Reply all
Reply to author
Forward
0 new messages