Received: by 10.224.180.141 with SMTP id bu13mr12279744qab.2.1351540241446;
        Mon, 29 Oct 2012 12:50:41 -0700 (PDT)
X-BeenThere: chromium-os-revi...@chromium.org
Received: by 10.224.97.129 with SMTP id l1ls1228266qan.6.gmail; Mon, 29 Oct
 2012 12:50:40 -0700 (PDT)
Received: by 10.49.3.227 with SMTP id f3mr23591370qef.60.1351540240767;
        Mon, 29 Oct 2012 12:50:40 -0700 (PDT)
Received: by 10.49.3.227 with SMTP id f3mr23591368qef.60.1351540240749;
        Mon, 29 Oct 2012 12:50:40 -0700 (PDT)
Return-Path: <ger...@chromium.org>
Received: from ns1.golo.chromium.org (postal.chromium.org [74.125.248.75])
        by mx.google.com with ESMTP id q17si3281478qct.95.2012.10.29.12.50.40;
        Mon, 29 Oct 2012 12:50:40 -0700 (PDT)
Received-SPF: pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) client-ip=74.125.248.75;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) smtp.mail=ger...@chromium.org
Message-Id: <508ede10.5188e50a.6020.5c78SMTPIN_ADDED@mx.google.com>
Received: from 192.168.20.14 (gerrit.golo.chromium.org [192.168.20.14])
	by ns1.golo.chromium.org (Postfix) with ESMTP id 2BF5E1614A2;
	Mon, 29 Oct 2012 12:50:40 -0700 (PDT)
Date: Mon, 29 Oct 2012 12:50:40 -0700
From: "Ryan Cui (Code Review)" <ger...@chromium.org>
To: Ryan Cui <r...@chromium.org>
CC: David James <davidja...@chromium.org>,
	Chris Sosa <s...@chromium.org>,
	Mike Frysinger <vap...@chromium.org>,
	Peter Mayo <peterm...@chromium.org>,
	Gerrit <chrome-...@google.com>
Reply-To: r...@chromium.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?Enable_deploy=5Fchrome.py_to_deploy_from_a_build_output_direct...__[chromiumos/chromite_:_master]=0A?=
X-Gerrit-Change-Id: I25bc3f5afc0fd80fd5e664c75cbd3524b9716831
Mailing-List: list gerrit-chromiumos-chrom...@gerrit.chromium.org
List-Id: <gerrit-chromiumos-chromite.gerrit.chromium.org>
List-Unsubscribe: <https://gerrit.chromium.org/gerrit/settings>
X-Gerrit-ChangeURL: <https://gerrit.chromium.org/gerrit/36020>
X-Gerrit-Commit: 67e632263b136969b1661d2f72a16833a192ae2b
In-Reply-To: <gerrit.1350610877926.I25bc3f5afc0fd80fd5e664c75cbd3524b9716...@gerrit.chromium.org>
References: <gerrit.1350610877926.I25bc3f5afc0fd80fd5e664c75cbd3524b9716...@gerrit.chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.4.2

Ryan Cui has posted comments on this change.

Change subject: Enable deploy_chrome.py to deploy from a build output directory.
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File lib/chrome_util.py
Line 20: # Taken from gyp/pylib.
There is no separate repo for gyp's pylib - just the 'external/gyp.git' repository.  I don't think we should be pulling the entire repo down just for this one function, which is not even gyp-specific (can be applied to any name value list...)

--
To view, visit https://gerrit.chromium.org/gerrit/36020
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25bc3f5afc0fd80fd5e664c75cbd3524b9716831
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Ryan Cui <r...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Peter Mayo <peterm...@chromium.org>
Gerrit-Reviewer: Ryan Cui <r...@chromium.org>