Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
Message from discussion Rework RetryCommand so it's usable beyond just RunCommand ta... [chromiumos/chromite : master]
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
David James (Code Review)  
View profile  
 More options Oct 31 2012, 2:37 pm
From: "David James (Code Review)" <ger...@chromium.org>
Date: Wed, 31 Oct 2012 11:37:57 -0700
Local: Wed, Oct 31 2012 2:37 pm
Subject: Rework RetryCommand so it's usable beyond just RunCommand ta... [chromiumos/chromite : master]
Print | View thread | Show original | Find messages by this author
David James has posted comments on this change.

Change subject: Rework RetryCommand so it's usable beyond just RunCommand targets.
......................................................................

Patch Set 3: (2 inline comments)

....................................................
File lib/cros_build_lib.py
Line 1573:     except (SystemExit, KeyboardInterrupt):
This is unnecessary, since these exceptions inherit from BaseException, not Exception:

  >>> isinstance(KeyboardInterrupt(), Exception)
  False
  >>> isinstance(SystemExit(), Exception)
  False

Line 1581:         exc_info = sys.exc_info()
Warning: Assigning the traceback return value to a local variable in a function that is handling an exception will cause a circular reference. (See http://effbot.org/pyref/sys.exc_info.htm)

--
To view, visit https://gerrit.chromium.org/gerrit/36607
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117e399c34d16d86f3df6b7eac878e15be025d9e
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Brian Harring <ferri...@chromium.org>
Gerrit-Reviewer: Brian Harring <ferri...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Ryan Cui <r...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google