Received: by 10.58.229.232 with SMTP id st8mr2819817vec.34.1352081844012;
        Sun, 04 Nov 2012 18:17:24 -0800 (PST)
X-BeenThere: chromium-os-revi...@chromium.org
Received: by 10.220.156.210 with SMTP id y18ls5010828vcw.2.gmail; Sun, 04 Nov
 2012 18:17:23 -0800 (PST)
Received: by 10.58.198.164 with SMTP id jd4mr8482782vec.34.1352081842953;
        Sun, 04 Nov 2012 18:17:22 -0800 (PST)
Received: by 10.58.198.164 with SMTP id jd4mr8482781vec.34.1352081842939;
        Sun, 04 Nov 2012 18:17:22 -0800 (PST)
Return-Path: <ger...@chromium.org>
Received: from ns1.golo.chromium.org (postal.chromium.org [74.125.248.75])
        by mx.google.com with ESMTP id et8si10122272vdb.102.2012.11.04.18.17.22;
        Sun, 04 Nov 2012 18:17:22 -0800 (PST)
Received-SPF: pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) client-ip=74.125.248.75;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of ger...@chromium.org designates 74.125.248.75 as permitted sender) smtp.mail=ger...@chromium.org
Message-Id: <509721b2.e863340a.6cb8.1185SMTPIN_ADDED@mx.google.com>
Received: from 192.168.20.14 (gerrit.golo.chromium.org [192.168.20.14])
	by ns1.golo.chromium.org (Postfix) with ESMTP id 1392316149C;
	Sun,  4 Nov 2012 18:17:22 -0800 (PST)
Date: Sun, 4 Nov 2012 18:17:22 -0800
From: "Tom Wai-Hong Tam (Code Review)" <ger...@chromium.org>
To: Vic Yang <victory...@chromium.org>
CC: Gerrit <chrome-...@google.com>, Mike Truty <tr...@chromium.org>,
	Vadim Bendebury <vben...@chromium.org>
Reply-To: waih...@chromium.org
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?firmware=5FECThermal:_Fix_a_wrong_exception_type_[chromiumos/third=5Fparty/autotest_:_master]=0A?=
X-Gerrit-Change-Id: I84b13cc6e585a301c677fc47d542b0358c626245
Mailing-List: list gerrit-chromiumos-third_party-autot...@gerrit.chromium.org
List-Id: <gerrit-chromiumos-third_party-autotest.gerrit.chromium.org>
List-Unsubscribe: <https://gerrit.chromium.org/gerrit/settings>
X-Gerrit-ChangeURL: <https://gerrit.chromium.org/gerrit/37319>
X-Gerrit-Commit: 71db184879d7eaaba3554b6f38f08c764a59e934
In-Reply-To: <gerrit.1351915425291.I84b13cc6e585a301c677fc47d542b0358c626...@gerrit.chromium.org>
References: <gerrit.1351915425291.I84b13cc6e585a301c677fc47d542b0358c626...@gerrit.chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.4.2

Tom Wai-Hong Tam has posted comments on this change.

Change subject: firmware_ECThermal: Fix a wrong exception type
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

LGTM w/ a nit.

....................................................
File server/site_tests/firmware_ECThermal/firmware_ECThermal.py
Line 193:         Raises:
Please also change this exception.

--
To view, visit https://gerrit.chromium.org/gerrit/37319
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b13cc6e585a301c677fc47d542b0358c626245
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victory...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <waih...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vben...@chromium.org>