firmware_ECThermal: Fix a wrong exception type [chromiumos/third_party/autotest : master]

13 views
Skip to first unread message

Vic Yang (Code Review)

unread,
Nov 3, 2012, 12:03:45 AM11/3/12
to
Vic Yang has uploaded a new change for review.

Change subject: firmware_ECThermal: Fix a wrong exception type
......................................................................

firmware_ECThermal: Fix a wrong exception type

BUG=chrome-os-partner:11714
TEST=none

Change-Id: I84b13cc6e585a301c677fc47d542b0358c626245
Signed-off-by: Vic Yang <victo...@chromium.org>
---
M server/site_tests/firmware_ECThermal/firmware_ECThermal.py
1 file changed, 1 insertion(+), 1 deletion(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/19/37319/1
--
To view, visit https://gerrit.chromium.org/gerrit/37319
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84b13cc6e585a301c677fc47d542b0358c626245
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>

Tom Wai-Hong Tam (Code Review)

unread,
Nov 4, 2012, 9:17:22 PM11/4/12
to Vic Yang, Gerrit, Mike Truty, Vadim Bendebury
Tom Wai-Hong Tam has posted comments on this change.

Change subject: firmware_ECThermal: Fix a wrong exception type
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

LGTM w/ a nit.

....................................................
File server/site_tests/firmware_ECThermal/firmware_ECThermal.py
Line 193: Raises:
Please also change this exception.

--
To view, visit https://gerrit.chromium.org/gerrit/37319
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b13cc6e585a301c677fc47d542b0358c626245
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>

Vic Yang (Code Review)

unread,
Nov 4, 2012, 9:27:36 PM11/4/12
to Gerrit, Mike Truty, Vadim Bendebury, Tom Wai-Hong Tam
Vic Yang has posted comments on this change.

Change subject: firmware_ECThermal: Fix a wrong exception type
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

Fixed. Carrying forward LGTM. Thanks.

--
To view, visit https://gerrit.chromium.org/gerrit/37319
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b13cc6e585a301c677fc47d542b0358c626245
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victo...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Gerrit-Reviewer: Vic Yang <victo...@chromium.org>
Reply all
Reply to author
Forward
0 new messages