Add touchscreen SYN_DROPPED test [chromiumos/third_party/autotest : master]

28 views
Skip to first unread message

Chung-yih Wang (Code Review)

unread,
Oct 30, 2012, 10:12:40 AM10/30/12
to
Chung-yih Wang has uploaded a new change for review.

Change subject: Add touchscreen SYN_DROPPED test
......................................................................

Add touchscreen SYN_DROPPED test

The test bombards the evdev kernel driver to generate SYN_DROPPED event(s)
as the queue inside will be filled up quickly. Therefore, we should be able
to see the SYN_DROPPED event and process it inside xf86-input-evdev driver
by examining the log file Xorg.0.log.

BUG=chromium-os:35291
TEST=on device; follow the steps
1. Modify the line in /sbin/xstart.sh to change the nice level from -20 to 19.

exec nice -n 19 /usr/bin/X -noreset -nolisten tcp vt01 -auth $1 2> /dev/null

2. Execute the test script to genereate the SYN_DROPPED event and see if it passes the test.
cd /usr/local/autotest
bin/autotest tests/platform_TouchscreenSynDrop/control

3. Test if touchscreen still functions correctly.

Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
---
A client/site_tests/platform_TouchscreenSynDrop/control
A client/site_tests/platform_TouchscreenSynDrop/gestures/bombard.dat
A client/site_tests/platform_TouchscreenSynDrop/platform_TouchscreenSynDrop.py
3 files changed, 14,980 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/96/36896/1
--
To view, visit https://gerrit.chromium.org/gerrit/36896
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>

Andrew de los Reyes (Code Review)

unread,
Oct 30, 2012, 2:24:54 PM10/30/12
to Chung-yih Wang, Gerrit, Daniel Kurtz, Joseph Shyh-In Hwang
Andrew de los Reyes has posted comments on this change.

Change subject: Add touchscreen SYN_DROPPED test
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File client/site_tests/platform_TouchscreenSynDrop/gestures/bombard.dat
Line 1: E: 1351148442.000001 0003 0039 166
i noticed in the other file, you seem to bombard the driver w/ 100 events. Does that mean you only need 100 lines from this file?

--
To view, visit https://gerrit.chromium.org/gerrit/36896
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>
Gerrit-Reviewer: Andrew de los Reyes <ad...@chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djk...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Joseph Shyh-In Hwang <jose...@chromium.org>

Chung-yih Wang (Code Review)

unread,
Oct 30, 2012, 11:46:05 PM10/30/12
to Gerrit, Daniel Kurtz, Joseph Shyh-In Hwang, Andrew de los Reyes
Chung-yih Wang has posted comments on this change.

Change subject: Add touchscreen SYN_DROPPED test
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File client/site_tests/platform_TouchscreenSynDrop/gestures/bombard.dat
Line 1: E: 1351148442.000001 0003 0039 166
As the evdev X driver is simpler than cmt, it consumes events with faster speed. So we need to slow down the X with higher nice level and also feed more events to fill up the pipe.

--
To view, visit https://gerrit.chromium.org/gerrit/36896
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>
Gerrit-Reviewer: Andrew de los Reyes <ad...@chromium.org>
Gerrit-Reviewer: Chung-yih Wang <cyw...@chromium.org>

Joseph Shyh-In Hwang (Code Review)

unread,
Oct 31, 2012, 2:15:10 AM10/31/12
to Chung-yih Wang, Gerrit, Daniel Kurtz, Andrew de los Reyes
Joseph Shyh-In Hwang has posted comments on this change.

Change subject: Add touchscreen SYN_DROPPED test
......................................................................


Patch Set 1: (3 inline comments)

Just some minor nits.

....................................................
File client/site_tests/platform_TouchscreenSynDrop/platform_TouchscreenSynDrop.py
Line 10: import utils
One blank line before "import utils"

Line 20: class platform_TouchscreenSynDrop(test.test):
Docstring for this class or for this module?

Line 51: player.playback(device, self.gestures_dir + '/bombard.dat')
Use os.path.join() for concatenation of sub-paths?

--
To view, visit https://gerrit.chromium.org/gerrit/36896
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>

Chung-yih Wang (Code Review)

unread,
Oct 31, 2012, 11:15:54 PM10/31/12
to Gerrit, Daniel Kurtz, Joseph Shyh-In Hwang, Andrew de los Reyes
Chung-yih Wang has posted comments on this change.

Change subject: Add touchscreen SYN_DROPPED test
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File client/site_tests/platform_TouchscreenSynDrop/platform_TouchscreenSynDrop.py
Line 10: import utils
Done

Line 20: class platform_TouchscreenSynDrop(test.test):
Done

Line 51: player.playback(device, self.gestures_dir + '/bombard.dat')
Done

--
To view, visit https://gerrit.chromium.org/gerrit/36896
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>

Joseph Shyh-In Hwang (Code Review)

unread,
Nov 1, 2012, 12:22:03 AM11/1/12
to Chung-yih Wang, Gerrit, Daniel Kurtz, Andrew de los Reyes
Joseph Shyh-In Hwang has posted comments on this change.

Change subject: Add touchscreen SYN_DROPPED test
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/36896
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>

Chung-yih Wang (Code Review)

unread,
Nov 1, 2012, 12:25:34 AM11/1/12
to Gerrit, Daniel Kurtz, Joseph Shyh-In Hwang, Andrew de los Reyes
Chung-yih Wang has posted comments on this change.

Change subject: Add touchscreen SYN_DROPPED test
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/36896
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2d899ef5d5af5ad4cb8835b76c7f3d48af7715
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chung-yih Wang <cyw...@chromium.org>
Reply all
Reply to author
Forward
0 new messages